Skip to content

Conversation

@DennisPeriquet
Copy link
Contributor

This PR is in support of renaming the default branch for https://github.com/openshift/node-feature-discovery from 'master' to 'main'.

Unhold this PR only when:

/hold

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 5, 2025
@openshift-ci-robot
Copy link
Contributor

@DennisPeriquet: This pull request references Jira Issue OCPBUGS-52393, which is invalid:

  • expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR is in support of renaming the default branch for https://github.com/openshift/node-feature-discovery from 'master' to 'main'.

Unhold this PR only when:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2025
@openshift-ci openshift-ci bot requested review from hector-vido and liangxia August 5, 2025 18:57
@DennisPeriquet
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 5, 2025
@openshift-ci-robot
Copy link
Contributor

@DennisPeriquet: This pull request references Jira Issue OCPBUGS-52393, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DennisPeriquet
Copy link
Contributor Author

/retest config

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2025

@DennisPeriquet: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test app-ci-config-dry
/test boskos-config
/test boskos-config-generation
/test build01-dry
/test build03-dry
/test build04-dry
/test build05-dry
/test build06-dry
/test build07-dry
/test build09-dry
/test build10-dry
/test build11-dry
/test check-gh-automation
/test check-gh-automation-tide
/test ci-operator-config
/test ci-operator-config-metadata
/test ci-operator-registry
/test ci-secret-bootstrap-config-validation
/test ci-testgrid-allow-list
/test clusterimageset-validate
/test config
/test core-valid
/test generated-config
/test generated-dashboards
/test hosted-mgmt-dry
/test image-mirroring-config-validation
/test jira-lifecycle-config
/test openshift-image-mirror-mappings
/test ordered-prow-config
/test owners
/test pr-reminder-config
/test prow-config
/test prow-config-filenames
/test prow-config-semantics
/test pylint
/test release-config
/test release-controller-config
/test rover-groups-config-validation
/test secret-generator-config-valid
/test services-valid
/test stackrox-stackrox-stackrox-stackrox-check
/test step-registry-metadata
/test step-registry-shellcheck
/test sync-rover-groups
/test vsphere02-dry
/test yamllint

The following commands are available to trigger optional jobs:

/test build02-dry
/test check-cluster-profiles-config

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-release-check-gh-automation
pull-ci-openshift-release-master-ci-operator-config
pull-ci-openshift-release-master-ci-operator-config-metadata
pull-ci-openshift-release-master-ci-operator-registry
pull-ci-openshift-release-master-config
pull-ci-openshift-release-master-core-valid
pull-ci-openshift-release-master-generated-config
pull-ci-openshift-release-master-ordered-prow-config
pull-ci-openshift-release-master-owners
pull-ci-openshift-release-master-prow-config-filenames
pull-ci-openshift-release-master-prow-config-semantics
pull-ci-openshift-release-master-release-controller-config
pull-ci-openshift-release-master-services-valid
pull-ci-openshift-release-openshift-image-mirror-mappings
pull-ci-openshift-release-yamllint

In response to this:

/retest config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@DennisPeriquet
Copy link
Contributor Author

/test config

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2025
@DennisPeriquet DennisPeriquet force-pushed the OCPBUGS-52393_node-feature-discovery_master-1 branch from dc8fa30 to 43d94cc Compare August 11, 2025 02:48
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2025
@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 10, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2025
@DennisPeriquet DennisPeriquet force-pushed the OCPBUGS-52393_node-feature-discovery_master-1 branch from 43d94cc to 8f92546 Compare September 11, 2025 15:18
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2025
@DennisPeriquet
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2025
@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2025
@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2025
@DennisPeriquet
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 13, 2025
@DennisPeriquet DennisPeriquet force-pushed the OCPBUGS-52393_node-feature-discovery_master-1 branch from 8f92546 to d83aa8e Compare October 13, 2025 11:10
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@DennisPeriquet: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-node-feature-discovery-main-images openshift/node-feature-discovery presubmit Presubmit changed
pull-ci-openshift-node-feature-discovery-main-unit openshift/node-feature-discovery presubmit Presubmit changed
pull-ci-openshift-node-feature-discovery-main-verify openshift/node-feature-discovery presubmit Presubmit changed
pull-ci-openshift-node-feature-discovery-main-verify-deps openshift/node-feature-discovery presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@DennisPeriquet
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-node-feature-discovery-main-images

@openshift-ci-robot
Copy link
Contributor

@DennisPeriquet: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@DennisPeriquet
Copy link
Contributor Author

/pj-rehearse ack
/hold cancel

@openshift-ci-robot
Copy link
Contributor

@DennisPeriquet: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

@DennisPeriquet: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7113136 into openshift:master Oct 13, 2025
16 checks passed
@openshift-ci-robot
Copy link
Contributor

@DennisPeriquet: Jira Issue OCPBUGS-52393: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-52393 has been moved to the MODIFIED state.

In response to this:

This PR is in support of renaming the default branch for https://github.com/openshift/node-feature-discovery from 'master' to 'main'.

Unhold this PR only when:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tbuskey pushed a commit to tbuskey/release that referenced this pull request Oct 14, 2025
…penshift#67853)

* OCPBUGS-52393: rename 'master' to 'main' for node-feature-discovery

* OCPBUGS-52393: run 'make jobs'
abhay-nutanix pushed a commit to abhay-nutanix/release that referenced this pull request Oct 16, 2025
…penshift#67853)

* OCPBUGS-52393: rename 'master' to 'main' for node-feature-discovery

* OCPBUGS-52393: run 'make jobs'
wangke19 pushed a commit to wangke19/release that referenced this pull request Oct 16, 2025
…penshift#67853)

* OCPBUGS-52393: rename 'master' to 'main' for node-feature-discovery

* OCPBUGS-52393: run 'make jobs'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants