Skip to content

CAPO: use rhel8 base image to run unit tests #39007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
May 9, 2023
Merged

CAPO: use rhel8 base image to run unit tests #39007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...enshift/cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@ build_root:
image_stream_tag:
name: release
namespace: openshift
tag: golang-1.17
tag: rhel-8-release-golang-1.19-openshift-4.14
resources:
'*':
requests:
cpu: 100m
memory: 200Mi
tests:
- as: unit
commands: make test
commands: GOFLAGS= XDG_DATA_HOME=/tmp/.local/share XDG_CACHE_HOME=/tmp/.cache make
Copy link
Member

@pierreprinetti pierreprinetti May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we vendor dependencies (as a downstream patch) and remove the GOFLAGS override?

Copy link
Member Author

@mandre mandre May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly, but since we're only using CAPO as a library in MAPO (we vendor in MAPO), is it important?

test
container:
from: src
optional: true
Expand Down