Add new job: e2e-vsphere-ovn-upgrade-check-dev-symlinks (#69787)

The job saves symlinks to root device, then does upgrade, then checks that all links are still present and point to root device

Author: mpatlasov

ci-operator/config/openshift/cluster-storage-operator/.config.prowgen

@@ -9,3 +9,4 @@ slack_reporter:
   - periodic-e2e-aws-ovn-upgrade-check-dev-symlinks
   - periodic-e2e-aws-selinux-alpha
   - periodic-e2e-gcp-ovn-upgrade-check-dev-symlinks
+  - periodic-e2e-vsphere-ovn-upgrade-check-dev-symlinks

ci-operator/config/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-4.21__periodics.yaml

@@ -3,6 +3,14 @@ base_images:
     name: "4.21"
     namespace: ocp
     tag: cluster-storage-operator-test
+  upi-installer:
+    name: "4.21"
+    namespace: ocp
+    tag: upi-installer
+  vsphere-ci-python:
+    name: vsphere-python
+    namespace: ci
+    tag: latest
 build_root:
   from_repository: true
 releases:
@@ -22,6 +30,14 @@ resources:
       cpu: 100m
       memory: 200Mi
 tests:
+- as: periodic-e2e-vsphere-ovn-upgrade-check-dev-symlinks
+  cron: '@daily'
+  steps:
+    cluster_profile: vsphere-elastic
+    observers:
+      enable:
+      - observers-resource-watch
+    workflow: openshift-upgrade-vsphere-storage-symlinks
 - as: periodic-e2e-aws-ovn-upgrade-check-dev-symlinks
   cron: '@daily'
   steps:

ci-operator/jobs/openshift/cluster-storage-operator/openshift-cluster-storage-operator-release-4.21-periodics.yaml

@@ -161,3 +161,84 @@ periodics:
     - name: result-aggregator
       secret:
         secretName: result-aggregator
+- agent: kubernetes
+  cluster: vsphere02
+  cron: 47 3 * * *
+  decorate: true
+  extra_refs:
+  - base_ref: release-4.21
+    org: openshift
+    repo: cluster-storage-operator
+  labels:
+    ci-operator.openshift.io/cloud: vsphere
+    ci-operator.openshift.io/cloud-cluster-profile: vsphere-elastic
+    ci-operator.openshift.io/variant: periodics
+    ci.openshift.io/generator: prowgen
+    job-release: "4.21"
+    pj-rehearse.openshift.io/can-be-rehearsed: "true"
+  name: periodic-ci-openshift-cluster-storage-operator-release-4.21-periodics-periodic-e2e-vsphere-ovn-upgrade-check-dev-symlinks
+  reporter_config:
+    slack:
+      channel: '#forum-ocp-storage'
+      job_states_to_report:
+      - failure
+      - error
+      report_template: |
+        ':red_jenkins_circle: Job *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs>'
+  spec:
+    containers:
+    - args:
+      - --gcs-upload-secret=/secrets/gcs/service-account.json
+      - --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
+      - --lease-server-credentials-file=/etc/boskos/credentials
+      - --report-credentials-file=/etc/report/credentials
+      - --secret-dir=/secrets/ci-pull-credentials
+      - --target=periodic-e2e-vsphere-ovn-upgrade-check-dev-symlinks
+      - --variant=periodics
+      command:
+      - ci-operator
+      image: quay-proxy.ci.openshift.org/openshift/ci:ci_ci-operator_latest
+      imagePullPolicy: Always
+      name: ""
+      resources:
+        requests:
+          cpu: 10m
+      volumeMounts:
+      - mountPath: /etc/boskos
+        name: boskos
+        readOnly: true
+      - mountPath: /secrets/ci-pull-credentials
+        name: ci-pull-credentials
+        readOnly: true
+      - mountPath: /secrets/gcs
+        name: gcs-credentials
+        readOnly: true
+      - mountPath: /secrets/manifest-tool
+        name: manifest-tool-local-pusher
+        readOnly: true
+      - mountPath: /etc/pull-secret
+        name: pull-secret
+        readOnly: true
+      - mountPath: /etc/report
+        name: result-aggregator
+        readOnly: true
+    serviceAccountName: ci-operator
+    volumes:
+    - name: boskos
+      secret:
+        items:
+        - key: credentials
+          path: credentials
+        secretName: boskos-credentials
+    - name: ci-pull-credentials
+      secret:
+        secretName: ci-pull-credentials
+    - name: manifest-tool-local-pusher
+      secret:
+        secretName: manifest-tool-local-pusher
+    - name: pull-secret
+      secret:
+        secretName: registry-pull-credentials
+    - name: result-aggregator
+      secret:
+        secretName: result-aggregator

ci-operator/step-registry/openshift/upgrade/vsphere/storage-symlinks/OWNERS

@@ -0,0 +1,5 @@
+approvers:
+- storage-approvers
+
+reviewers:
+- storage-reviewers

ci-operator/step-registry/openshift/upgrade/vsphere/storage-symlinks/openshift-upgrade-vsphere-storage-symlinks-workflow.metadata.json

@@ -0,0 +1,11 @@
+{
+	"path": "openshift/upgrade/vsphere/storage-symlinks/openshift-upgrade-vsphere-storage-symlinks-workflow.yaml",
+	"owners": {
+		"approvers": [
+			"storage-approvers"
+		],
+		"reviewers": [
+			"storage-reviewers"
+		]
+	}
+}

ci-operator/step-registry/openshift/upgrade/vsphere/storage-symlinks/openshift-upgrade-vsphere-storage-symlinks-workflow.yaml

@@ -0,0 +1,20 @@
+workflow:
+  as: openshift-upgrade-vsphere-storage-symlinks
+  steps:
+    pre:
+    - chain: ipi-vsphere-pre-stableinitial
+    test:
+    - ref: storage-disk-symlinks-save
+    - ref: openshift-e2e-test
+    - ref: storage-disk-symlinks-check
+    post:
+    - chain: ipi-vsphere-post
+    dependencies:
+      OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: "release:initial"
+      OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE: "release:latest"
+    env:
+      TEST_TYPE: upgrade
+      TEST_SUITE: ""
+      TEST_UPGRADE_OPTIONS: ""
+  documentation: |-
+    The Openshift E2E vSphere workflow executes the upgrade end-to-end test suite on vSphere with a default cluster configuration checking that root device symlinks are in place after upgrade. The purpose is make sure that udev rules are stable across upgrades.