From 9260dcd084f19ec5a641c2673525163d5ab76816 Mon Sep 17 00:00:00 2001 From: David Moreau-Simard Date: Sun, 21 May 2017 14:45:21 -0400 Subject: [PATCH] Allow a hostname to resolve to 127.0.0.1 during validation 127.0.0.1 does not end up in "ansible_all_ipv4_addresses" and should be considered valid. For example, a hostname could be resolving to a public address that is not bound to the actual server. Or the host could resolve to 127.0.0.1 from the perspective of the host since the hostname is set up in /etc/hosts. --- playbooks/common/openshift-cluster/validate_hostnames.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/playbooks/common/openshift-cluster/validate_hostnames.yml b/playbooks/common/openshift-cluster/validate_hostnames.yml index 48cc03b19ef..33fc5630f00 100644 --- a/playbooks/common/openshift-cluster/validate_hostnames.yml +++ b/playbooks/common/openshift-cluster/validate_hostnames.yml @@ -13,4 +13,6 @@ pause: prompt: "The hostname \"{{ openshift.common.hostname }}\" for \"{{ ansible_nodename }}\" doesn't resolve to an ip address owned by this host. Please set openshift_hostname variable to a hostname that when resolved on the host in question resolves to an IP address matching an interface on this host. This host will fail liveness checks for pods utilizing hostPorts, press ENTER to continue or CTRL-C to abort." seconds: "{{ 10 if openshift_override_hostname_check | default(false) | bool else omit }}" - when: lookupip.stdout not in ansible_all_ipv4_addresses + when: + - lookupip.stdout != '127.0.0.1' + - lookupip.stdout not in ansible_all_ipv4_addresses