Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The added private registry will be covered during the integration tests #4343

Closed
zhengxiaomei123 opened this issue Jan 5, 2021 · 4 comments
Labels
area/System-PZ Issues related to IBM System Z and System P kind/bug Categorizes issue or PR as related to a bug.

Comments

@zhengxiaomei123
Copy link
Contributor

/kind bug

What versions of software are you using?

Operating System:

Output of odo version:
the latest version

How did you run odo exactly?

odo registry add IBMDevfilesRegistry https://github.com/zhengxiaomei123/devfile-registry --token xxxx

Actual behavior

The registry is not changed.

Expected behavior

The private registry can be used for devfiles related deployments.

Any logs, error output, etc?

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 5, 2021
@zhengxiaomei123
Copy link
Contributor Author

zhengxiaomei123 commented Jan 5, 2021

/area System-PZ

@openshift-ci-robot openshift-ci-robot added the area/System-PZ Issues related to IBM System Z and System P label Jan 5, 2021
@zhengxiaomei123
Copy link
Contributor Author

odo registry list
NAME URL SECURE
IBMDevfilesRegistry https://github.com/zhengxiaomei123/devfile-registry Yes
We can add it but after running the integration tests, the registry is changed to default registry .

@zhengxiaomei123 zhengxiaomei123 changed the title Can't add private registry for Devfiles on P&Z The added private registry will be covered during the integration tests Jan 11, 2021
@zhengxiaomei123
Copy link
Contributor Author

The private devfiles registry could be added successfully and use it to run integration tests for devfiles feature. But there are some test cases which will add DefaultDevfileRegistry back which will cause the later tests failure. For example:

Context("When executing catalog describe component with a component name with multiple components", func() {
                It("should print multiple devfiles from different registries", func() {
                        helper.CmdShouldPass("odo", "registry", "add", registryName, addRegistryURL)
                        output := helper.CmdShouldPass("odo", "catalog", "describe", "component", "nodejs")
                        helper.MatchAllInOutput(output, []string{"name: nodejs-starter", "Registry: " + registryName})
                })
        })

@zhengxiaomei123
Copy link
Contributor Author

close this issue since it be resoved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/System-PZ Issues related to IBM System Z and System P kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants