Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odo create: --s2i flag is broken #4048

Closed
devang-gaur opened this issue Sep 28, 2020 · 0 comments · Fixed by #4075
Closed

odo create: --s2i flag is broken #4048

devang-gaur opened this issue Sep 28, 2020 · 0 comments · Fixed by #4075
Assignees
@devang-gaur
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/Critical We need to stop doing everything and fix this ASAP. It is making the project unusable.

Comments

@devang-gaur
Copy link
Contributor

devang-gaur commented Sep 28, 2020 •
edited
Loading

/kind bug

  1. If a devfile component already exists in the working file directory, odo create <cmpType> --s2i does not error out.

    image

  2. Another bug has been introduced at https://github.com/openshift/odo/blame/master/pkg/odo/cli/component/create.go#L349 .
    The if !co.forceS2i { } block has logic inside like https://github.com/openshift/odo/blame/master/pkg/odo/cli/component/create.go#L377 & https://github.com/openshift/odo/blame/master/pkg/odo/cli/component/create.go#L351 .. which requires co.forceS2i == true. This code will never execute since the outer blog requires co.forceS2i == false . Therefore, conflicting flags are not being checked properly either.
@devang-gaur devang-gaur added kind/bug Categorizes issue or PR as related to a bug. area/component labels Sep 28, 2020
@devang-gaur devang-gaur self-assigned this Sep 28, 2020
@devang-gaur devang-gaur mentioned this issue Oct 3, 2020
Merged
@rm3l rm3l added priority/Critical We need to stop doing everything and fix this ASAP. It is making the project unusable. and removed priority/critical-urgent labels Jun 18, 2023
@rm3l rm3l added this to odo Project Jun 18, 2023
@rm3l rm3l moved this to Done ✅ in odo Project Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devang-gaur devang-gaur

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/Critical We need to stop doing everything and fix this ASAP. It is making the project unusable.
Projects
odo Project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: fix s2i flag for odo create devang-gaur/odo
2 participants
@rm3l @devang-gaur