Skip to content

daemon: Refuse to disable FIPS mode #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Nov 6, 2019
Merged

daemon: Refuse to disable FIPS mode #1233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions pkg/daemon/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,23 @@ func (dn *Daemon) updateFIPS(current, desired *mcfgv1.MachineConfig) error {
if dn.OperatingSystem != machineConfigDaemonOSRHCOS {
return errors.New("Updating FIPS on non-RHCOS nodes is not supported")
}
// Our new thought around this is that really FIPS should be a "day 1"
// operation, and we don't want to make it really easy to undo.
// See also https://github.com/openshift/installer/pull/2594
// Anyone who wants to force this can change the MC flag, then
// `oc debug node` and run the disable command by hand, then reboot.
if current.Spec.FIPS && !desired.Spec.FIPS {
return errors.New("Refusing to undo FIPS mode")
}
// At this point, we must be trying to enable FIPS, since
// current != desired && desired per conditionals above
if _, err := os.Stat(fipsCommand); err != nil {
if os.IsNotExist(err) {
return errors.New("Cannot enable FIPS after firstboot")
}
return errors.Wrapf(err, "Checking FIPS")
}

arg := "enable"
if !desired.Spec.FIPS {
arg = "disable"
Expand Down