Skip to content

install/telemetry: add prometheus alerts #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 2 commits into from
Nov 5, 2019
Merged

install/telemetry: add prometheus alerts #1223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f678ceb
fix mcddrain metric to accomodate easier prom alerting
kikisdeliveryservice Oct 31, 2019
6dac9f2
install/telemetry: add prometheus monitoring alerts
kikisdeliveryservice Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions install/0000_90_machine-config-operator_01_prometheus-rules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
apiVersion: monitoring.coreos.com/v1
kind: PrometheusRule
metadata:
name: machine-config-daemon
namespace: openshift-machine-config-operator
labels:
k8s-app: machine-config-daemon
spec:
groups:
- name: mcd-reboot-error
rules:
- alert: MCDRebootError
expr: |
mcd_reboot_err > 0
labels:
severity: critical
annotations:
message: "Reboot failed on {{ $labels.node }} , update may be blocked"
- name: mcd-drain-error
rules:
- alert: MCDDrainError
expr: |
mcd_drain > 0
labels:
severity: critical
annotations:
message: "Drain failed on {{ $labels.node }} , updates may be blocked. For more details: oc logs -f -n openshift-machine-config-operator machine-config-daemon-<hash> -c machine-config-daemon"
- name: mcd-pivot-error
rules:
- alert: MCDPivotError
expr: |
mcd_pivot_err > 0
labels:
severity: warning
annotations:
message: "Error detected in pivot logs on {{ $labels.node }} "
- name: mcd-kubelet-health-state-error
rules:
- alert: KubeletHealthState
expr: |
mcd_kubelet_state > 2
labels:
severity: warning
annotations:
message: "Kubelet health failure threshold reached"
2 changes: 1 addition & 1 deletion pkg/daemon/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ func (dn *Daemon) drain() error {
t := time.Since(startTime).Seconds()
glog.Infof("Successful drain took %v seconds", t)
successTime := fmt.Sprintf("%v sec", t)
MCDDrainErr.WithLabelValues(successTime, "").SetToCurrentTime()
MCDDrainErr.WithLabelValues(successTime, "").Set(0)

return nil
}
Expand Down