NO-JIRA: JN-2789: added H200 support #131

MenD32 · 2025-10-15T12:27:15Z

Currently OpenShift cannot create H200 machines since they are part of the a3 machineFamily but don't have a quota in the gcp compute library.

openshift-ci-robot · 2025-10-15T14:21:28Z

@MenD32: This pull request explicitly references no jira issue.

In response to this:

Currently OpenShift cannot create H200 machines since they are part of the a3 machineFamily but don't have a quota in the gcp compute library.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

elmiko

this makes sense to me, i do wonder if we shouldn't have some warning log message when we are skipping the accelerator validation. if there is no quota, or resource exhaustion, i'm not sure the user will be able to easily detect that.

elmiko · 2025-10-29T14:42:39Z

@MenD32 any thoughts about this question ?

also, cc @damdo ptal

damdo

/approve

One nit

pkg/cloud/gcp/actuators/machine/reconciler.go

openshift-ci · 2025-10-29T15:25:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

MenD32 · 2025-10-29T17:01:22Z

this makes sense to me, i do wonder if we shouldn't have some warning log message when we are skipping the accelerator validation. if there is no quota, or resource exhaustion, i'm not sure the user will be able to easily detect that.

I think this is somewhat broader then just H200 support, since this also affects other machine-types (g2, g4, a4, etc...). So I'm not sure how machine-api-provider should work with those...

MenD32 · 2025-10-29T19:58:12Z

/retest

damdo

/lgtm

damdo · 2025-10-30T10:21:20Z

@MenD32 do you have a Jira card to track this?

damdo · 2025-10-30T10:21:26Z

/hold

MenD32 · 2025-10-30T10:34:48Z

No, where should I open one?

damdo · 2025-10-30T10:47:15Z

@MenD32 probably on your team's Jira board

MenD32 · 2025-10-30T10:51:28Z

My team doesn't currently work on RH's Jira, so IDK if there'd integration between the GitHub and the Jira instance. Nevertheless I'll create an issue

openshift-ci-robot · 2025-10-30T10:53:25Z

@MenD32: No Jira issue with key JN-2789 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Currently OpenShift cannot create H200 machines since they are part of the a3 machineFamily but don't have a quota in the gcp compute library.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MenD32 · 2025-10-30T10:53:39Z

@MenD32 probably on your team's Jira board

Added a JIRA ticket reference

damdo · 2025-10-30T10:59:37Z

TY, I am chatting internally to see how best we test/verify this cc. @elmiko

damdo · 2025-11-12T08:55:01Z

Thanks for rebasing @MenD32

It looks like you created a merge commit for this, whereas we normally do a full rebase instead.
Could you please update the PR to reflect that? TY

Signed-off-by: Amit Mendelevitch <[email protected]>

Co-authored-by: Damiano Donati <[email protected]>

MenD32 · 2025-11-12T09:00:34Z

Thanks for rebasing @MenD32

It looks like you created a merge commit for this, whereas we normally do a full rebase instead. Could you please update the PR to reflect that? TY

for some reason it still wanted a merge after the rebase, I just redid the rebase and now it seems that its fine

damdo

/lgtm

/unhold

damdo · 2025-11-13T08:19:43Z

/jira refresh

openshift-ci-robot · 2025-11-13T08:19:46Z

@damdo: No Jira issue with key JN-2789 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-13T08:19:47Z

@damdo: The referenced Jira(s) [JN-2789] could not be located, all automatically applied jira labels will be removed.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sunzhaohua2 · 2025-11-13T08:20:00Z

/verified by @sunzhaohua2
https://redhat-internal.slack.com/archives/CBZHF4DHC/p1763012438945199?thread_ts=1762265368.286229&cid=CBZHF4DHC

openshift-ci-robot · 2025-11-13T08:20:11Z

@sunzhaohua2: This PR has been marked as verified by @sunzhaohua2.

In response to this:

/verified by @sunzhaohua2
https://redhat-internal.slack.com/archives/CBZHF4DHC/p1763012438945199?thread_ts=1762265368.286229&cid=CBZHF4DHC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-13T08:20:27Z

@MenD32: This pull request explicitly references no jira issue.

In response to this:

Currently OpenShift cannot create H200 machines since they are part of the a3 machineFamily but don't have a quota in the gcp compute library.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

damdo · 2025-11-13T08:21:05Z

Adding NO-JIRA as JN-2789 is not picked up by the OCP robot

damdo · 2025-11-13T08:21:21Z

/tide refresh

openshift-ci bot requested review from nrb and theobarberbany October 15, 2025 12:32

elmiko changed the title ~~fix: added H200 support~~ NO-JIRA: added H200 support Oct 15, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 15, 2025

elmiko reviewed Oct 15, 2025

View reviewed changes

damdo reviewed Oct 29, 2025

View reviewed changes

pkg/cloud/gcp/actuators/machine/reconciler.go Outdated Show resolved Hide resolved

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2025

MenD32 requested review from damdo and elmiko October 30, 2025 10:16

damdo reviewed Oct 30, 2025

View reviewed changes

openshift-ci bot assigned damdo Oct 30, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2025

MenD32 changed the title ~~NO-JIRA: added H200 support~~ JN-2789: added H200 support Oct 30, 2025

openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 30, 2025

MenD32 requested a review from damdo November 10, 2025 14:38

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2025

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2025

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2025

MenD32 and others added 2 commits November 12, 2025 10:59

fix: added H200 support

9e653a8

Signed-off-by: Amit Mendelevitch <[email protected]>

Update pkg/cloud/gcp/actuators/machine/reconciler.go

495f894

Co-authored-by: Damiano Donati <[email protected]>

MenD32 force-pushed the fix/support-h200-gpus branch from de6fa97 to 495f894 Compare November 12, 2025 08:59

damdo reviewed Nov 13, 2025

View reviewed changes

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 13, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 13, 2025

damdo changed the title ~~JN-2789: added H200 support~~ NO-JIRA: JN-2789: added H200 support Nov 13, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2025

openshift-merge-bot bot merged commit 8f59a1a into openshift:main Nov 13, 2025
10 checks passed

NO-JIRA: JN-2789: added H200 support #131

NO-JIRA: JN-2789: added H200 support #131

Uh oh!

Conversation

MenD32 commented Oct 15, 2025

Uh oh!

openshift-ci-robot commented Oct 15, 2025

Uh oh!

elmiko left a comment

Choose a reason for hiding this comment

Uh oh!

elmiko commented Oct 29, 2025

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci bot commented Oct 29, 2025

Uh oh!

MenD32 commented Oct 29, 2025

Uh oh!

MenD32 commented Oct 29, 2025

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

damdo commented Oct 30, 2025

Uh oh!

damdo commented Oct 30, 2025

Uh oh!

MenD32 commented Oct 30, 2025

Uh oh!

damdo commented Oct 30, 2025

Uh oh!

MenD32 commented Oct 30, 2025

Uh oh!

openshift-ci-robot commented Oct 30, 2025

Uh oh!

MenD32 commented Oct 30, 2025

Uh oh!

damdo commented Oct 30, 2025

Uh oh!

damdo commented Nov 12, 2025

Uh oh!

MenD32 commented Nov 12, 2025

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

damdo commented Nov 13, 2025

Uh oh!

openshift-ci-robot commented Nov 13, 2025

Uh oh!

openshift-ci-robot commented Nov 13, 2025

Uh oh!

sunzhaohua2 commented Nov 13, 2025

Uh oh!

openshift-ci-robot commented Nov 13, 2025

Uh oh!

openshift-ci-robot commented Nov 13, 2025

Uh oh!

damdo commented Nov 13, 2025

Uh oh!

damdo commented Nov 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants