Skip to content

OCPBUGS-60704: add resourceread functions for ValidatingAdmissionPolicyV1 #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Aug 21, 2025
Merged

OCPBUGS-60704: add resourceread functions for ValidatingAdmissionPolicyV1 #2002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions pkg/operator/resource/resourceread/admission.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,21 @@ func ReadValidatingAdmissionPolicyBindingV1beta1OrDie(objBytes []byte) *admissio

return requiredObj.(*admissionv1beta1.ValidatingAdmissionPolicyBinding)
}

func ReadValidatingAdmissionPolicyV1OrDie(objBytes []byte) *admissionv1.ValidatingAdmissionPolicy {
requiredObj, err := runtime.Decode(admissionCodecs.UniversalDecoder(admissionv1.SchemeGroupVersion), objBytes)
if err != nil {
panic(err)
}

return requiredObj.(*admissionv1.ValidatingAdmissionPolicy)
}

func ReadValidatingAdmissionPolicyBindingV1OrDie(objBytes []byte) *admissionv1.ValidatingAdmissionPolicyBinding {
requiredObj, err := runtime.Decode(admissionCodecs.UniversalDecoder(admissionv1.SchemeGroupVersion), objBytes)
if err != nil {
panic(err)
}

return requiredObj.(*admissionv1.ValidatingAdmissionPolicyBinding)
}
46 changes: 46 additions & 0 deletions pkg/operator/resource/resourceread/admission_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,49 @@ webhooks:
t.Errorf("Expected a webhook, got nil")
}
}

func TestValidatingAdmissionPolicies(t *testing.T) {
validValidatingAdmissionPolicy := `
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingAdmissionPolicy
metadata:
name: "machine-configuration-guards"
spec:
failurePolicy: Fail
matchConstraints:
matchPolicy: Equivalent
namespaceSelector: {}
objectSelector: {}
resourceRules:
- apiGroups: ["operator.openshift.io"]
apiVersions: ["v1"]
operations: ["CREATE","UPDATE"]
resources: ["machineconfigurations"]
scope: "*"
validations:
- expression: "object.metadata.name=='cluster'"
message: "Only a single object of MachineConfiguration is allowed and it must be named cluster."
`
obj := ReadValidatingAdmissionPolicyV1OrDie([]byte(validValidatingAdmissionPolicy))
if obj == nil {
t.Errorf("Expected a validatingadmissionpolicy, got nil")
}

}

func TestValidatingAdmissionPolicyBindings(t *testing.T) {
validValidatingAdmissionPolicyBinding := `
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingAdmissionPolicyBinding
metadata:
name: "machine-configuration-guards-binding"
spec:
policyName: "machine-configuration-guards"
validationActions: [Deny]
`
obj := ReadValidatingAdmissionPolicyBindingV1OrDie([]byte(validValidatingAdmissionPolicyBinding))
if obj == nil {
t.Errorf("Expected a validatingadmissionpolicybinding, got nil")
}

}