Skip to content

Commit 834af76

Browse files
p0lyn0mialsoltysh
authored andcommitted
UPSTREAM: <carry>: conditionally fill the UserAgent from the currently running test
OpenShift uses these function before any test is run and they cause NPE openshift-rebase(v1.24):source=52b73523b4c
1 parent 8e73298 commit 834af76

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/e2e/framework/util.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -483,9 +483,9 @@ func restclientConfig(kubeContext string) (*clientcmdapi.Config, error) {
483483
type ClientConfigGetter func() (*restclient.Config, error)
484484

485485
// LoadConfig returns a config for a rest client with the UserAgent set to include the current test name.
486-
func LoadConfig() (config *restclient.Config, err error) {
486+
func LoadConfig(noUserAgent ...bool) (config *restclient.Config, err error) {
487487
defer func() {
488-
if err == nil && config != nil {
488+
if err == nil && config != nil && len(noUserAgent) == 0 {
489489
testDesc := ginkgo.CurrentSpecReport()
490490
if len(testDesc.ContainerHierarchyTexts) > 0 {
491491
testName := strings.Join(testDesc.ContainerHierarchyTexts, " ")
@@ -527,8 +527,8 @@ func LoadConfig() (config *restclient.Config, err error) {
527527
}
528528

529529
// LoadClientset returns clientset for connecting to kubernetes clusters.
530-
func LoadClientset() (*clientset.Clientset, error) {
531-
config, err := LoadConfig()
530+
func LoadClientset(noUserAgent ...bool) (*clientset.Clientset, error) {
531+
config, err := LoadConfig(noUserAgent...)
532532
if err != nil {
533533
return nil, fmt.Errorf("error creating client: %v", err.Error())
534534
}

0 commit comments

Comments
 (0)