diff --git a/pkg/asset/machines/azure/machinesets.go b/pkg/asset/machines/azure/machinesets.go index 9182d2399f2..a083f151f83 100644 --- a/pkg/asset/machines/azure/machinesets.go +++ b/pkg/asset/machines/azure/machinesets.go @@ -13,7 +13,7 @@ import ( ) // MachineSets returns a list of machinesets for a machinepool. -func MachineSets(clusterID string, config *types.InstallConfig, pool *types.MachinePool, osImage, role, userDataSecret string, capabilities map[string]string, rhcosVersion string) ([]*clusterapi.MachineSet, error) { +func MachineSets(clusterID string, config *types.InstallConfig, pool *types.MachinePool, osImage, role, userDataSecret string, capabilities map[string]string, useImageGallery bool) ([]*clusterapi.MachineSet, error) { if configPlatform := config.Platform.Name(); configPlatform != azure.Name { return nil, fmt.Errorf("non-azure configuration: %q", configPlatform) } @@ -41,7 +41,6 @@ func MachineSets(clusterID string, config *types.InstallConfig, pool *types.Mach if int64(idx) < total%numOfAZs { replicas++ } - useImageGallery := platform.CloudName != azure.StackCloud provider, err := provider(platform, mpool, osImage, userDataSecret, clusterID, role, &idx, capabilities, useImageGallery) if err != nil { return nil, errors.Wrap(err, "failed to create provider") diff --git a/pkg/asset/machines/worker.go b/pkg/asset/machines/worker.go index 7ada92a494c..c33ca8d3a1d 100644 --- a/pkg/asset/machines/worker.go +++ b/pkg/asset/machines/worker.go @@ -236,6 +236,7 @@ func (w *Worker) Generate(dependencies asset.Parents) error { var err error ic := installConfig.Config for _, pool := range ic.Compute { + pool := pool // this makes golint happy... G601: Implicit memory aliasing in for loop. (gosec) if pool.Hyperthreading == types.HyperthreadingDisabled { ignHT, err := machineconfig.ForHyperthreadingDisabled("worker") if err != nil { @@ -411,7 +412,8 @@ func (w *Worker) Generate(dependencies asset.Parents) error { return err } - sets, err := azure.MachineSets(clusterID.InfraID, ic, &pool, string(*rhcosImage), "worker", workerUserDataSecretName, capabilities, rhcosRelease.GetAzureReleaseVersion()) + useImageGallery := ic.Platform.Azure.CloudName != azuretypes.StackCloud + sets, err := azure.MachineSets(clusterID.InfraID, ic, &pool, string(*rhcosImage), "worker", workerUserDataSecretName, capabilities, useImageGallery) if err != nil { return errors.Wrap(err, "failed to create worker machine objects") }