diff --git a/data/data/aws/bootstrap/main.tf b/data/data/aws/bootstrap/main.tf index 11e896dba29..cf1cf2eeee1 100644 --- a/data/data/aws/bootstrap/main.tf +++ b/data/data/aws/bootstrap/main.tf @@ -109,7 +109,7 @@ resource "aws_instance" "bootstrap" { subnet_id = "${var.subnet_id}" user_data = "${data.ignition_config.redirect.rendered}" vpc_security_group_ids = ["${var.vpc_security_group_ids}"] - associate_public_ip_address = "${var.associate_public_ip_address}" + associate_public_ip_address = true lifecycle { # Ignore changes in the AMI which force recreation of the resource. This diff --git a/data/data/aws/bootstrap/variables.tf b/data/data/aws/bootstrap/variables.tf index 7b394643bc7..724d2ddf56a 100644 --- a/data/data/aws/bootstrap/variables.tf +++ b/data/data/aws/bootstrap/variables.tf @@ -3,11 +3,6 @@ variable "ami" { description = "The AMI ID for the bootstrap node." } -variable "associate_public_ip_address" { - default = false - description = "If set to true, public-facing ingress resources are created." -} - variable "cluster_name" { type = "string" description = "The name of the cluster." diff --git a/data/data/aws/main.tf b/data/data/aws/main.tf index 59ce2ea3f0f..3e7e9192657 100644 --- a/data/data/aws/main.tf +++ b/data/data/aws/main.tf @@ -1,31 +1,23 @@ locals { - private_endpoints = "${var.aws_endpoints == "public" ? false : true}" - public_endpoints = "${var.aws_endpoints == "private" ? false : true}" - private_zone_id = "${var.aws_external_private_zone != "" ? var.aws_external_private_zone : join("", aws_route53_zone.int.*.zone_id)}" + private_zone_id = "${aws_route53_zone.int.zone_id}" } provider "aws" { region = "${var.aws_region}" version = "1.39.0" - - assume_role { - role_arn = "${var.aws_installer_role == "" ? "" : "${var.aws_installer_role}"}" - session_name = "OPENSHIFT_INSTALLER_${var.cluster_name}" - } } module "bootstrap" { source = "./bootstrap" - ami = "${var.aws_ec2_ami_override}" - associate_public_ip_address = "${var.aws_endpoints != "private"}" - cluster_name = "${var.cluster_name}" - iam_role = "${var.aws_master_iam_role_name}" - ignition = "${var.ignition_bootstrap}" - subnet_id = "${module.vpc.master_subnet_ids[0]}" - target_group_arns = "${module.vpc.aws_lb_target_group_arns}" - target_group_arns_length = "${module.vpc.aws_lb_target_group_arns_length}" - vpc_security_group_ids = ["${concat(var.aws_master_extra_sg_ids, list(module.vpc.master_sg_id))}"] + ami = "${var.aws_ec2_ami_override}" + cluster_name = "${var.cluster_name}" + iam_role = "${var.aws_master_iam_role_name}" + ignition = "${var.ignition_bootstrap}" + subnet_id = "${module.vpc.master_subnet_ids[0]}" + target_group_arns = "${module.vpc.aws_lb_target_group_arns}" + target_group_arns_length = "${module.vpc.aws_lb_target_group_arns_length}" + vpc_security_group_ids = "${list(module.vpc.master_sg_id)}" tags = "${merge(map( "Name", "${var.cluster_name}-bootstrap", @@ -44,8 +36,7 @@ module "masters" { extra_tags = "${var.aws_extra_tags}" instance_count = "${var.master_count}" master_iam_role = "${var.aws_master_iam_role_name}" - master_sg_ids = "${concat(var.aws_master_extra_sg_ids, list(module.vpc.master_sg_id))}" - public_endpoints = "${local.public_endpoints}" + master_sg_ids = "${list(module.vpc.master_sg_id)}" root_volume_iops = "${var.aws_master_root_volume_iops}" root_volume_size = "${var.aws_master_root_volume_size}" root_volume_type = "${var.aws_master_root_volume_type}" @@ -72,35 +63,21 @@ module "dns" { api_internal_lb_zone_id = "${module.vpc.aws_lb_api_internal_zone_id}" base_domain = "${var.base_domain}" cluster_name = "${var.cluster_name}" - elb_alias_enabled = true master_count = "${var.master_count}" private_zone_id = "${local.private_zone_id}" - external_vpc_id = "${module.vpc.vpc_id}" extra_tags = "${var.aws_extra_tags}" - private_endpoints = "${local.private_endpoints}" - public_endpoints = "${local.public_endpoints}" } module "vpc" { source = "./vpc" - base_domain = "${var.base_domain}" - cidr_block = "${var.aws_vpc_cidr_block}" - cluster_id = "${var.cluster_id}" - cluster_name = "${var.cluster_name}" - external_vpc_id = "${var.aws_external_vpc_id}" - region = "${var.aws_region}" - - external_master_subnet_ids = "${compact(var.aws_external_master_subnet_ids)}" - external_worker_subnet_ids = "${compact(var.aws_external_worker_subnet_ids)}" - extra_tags = "${var.aws_extra_tags}" - - // empty map subnet_configs will have the vpc module creating subnets in all availabile AZs - new_master_subnet_configs = "${var.aws_master_custom_subnets}" - new_worker_subnet_configs = "${var.aws_worker_custom_subnets}" + base_domain = "${var.base_domain}" + cidr_block = "${var.aws_vpc_cidr_block}" + cluster_id = "${var.cluster_id}" + cluster_name = "${var.cluster_name}" + region = "${var.aws_region}" - private_master_endpoints = "${local.private_endpoints}" - public_master_endpoints = "${local.public_endpoints}" + extra_tags = "${var.aws_extra_tags}" } resource "aws_route53_record" "etcd_a_nodes" { @@ -121,7 +98,6 @@ resource "aws_route53_record" "etcd_cluster" { } resource "aws_route53_zone" "int" { - count = "${local.private_endpoints ? "${var.aws_external_private_zone == "" ? 1 : 0 }" : 0}" vpc_id = "${module.vpc.vpc_id}" name = "${var.base_domain}" force_destroy = true diff --git a/data/data/aws/master/main.tf b/data/data/aws/master/main.tf index cd4463cf79b..7cd0bb36050 100644 --- a/data/data/aws/master/main.tf +++ b/data/data/aws/master/main.tf @@ -84,7 +84,7 @@ resource "aws_instance" "master" { user_data = "${var.user_data_ign}" vpc_security_group_ids = ["${var.master_sg_ids}"] - associate_public_ip_address = "${var.public_endpoints}" + associate_public_ip_address = true lifecycle { # Ignore changes in the AMI which force recreation of the resource. This diff --git a/data/data/aws/master/variables.tf b/data/data/aws/master/variables.tf index f624eaa78ec..330970fce8f 100644 --- a/data/data/aws/master/variables.tf +++ b/data/data/aws/master/variables.tf @@ -51,11 +51,6 @@ variable "master_sg_ids" { description = "The security group IDs to be applied to the master nodes." } -variable "public_endpoints" { - description = "If set to true, public-facing ingress resources are created." - default = true -} - variable "root_volume_iops" { type = "string" default = "100" diff --git a/data/data/aws/route53/base.tf b/data/data/aws/route53/base.tf index 6e53975ffc9..d9f4d06dc07 100644 --- a/data/data/aws/route53/base.tf +++ b/data/data/aws/route53/base.tf @@ -1,21 +1,14 @@ -locals { - public_endpoints_count = "${var.public_endpoints ? 1 : 0}" - private_endpoints_count = "${var.private_endpoints ? 1 : 0}" -} - data "aws_route53_zone" "base" { name = "${var.base_domain}" } locals { - public_zone_id = "${join("", data.aws_route53_zone.base.*.zone_id)}" + public_zone_id = "${data.aws_route53_zone.base.zone_id}" - zone_id = "${var.private_endpoints ? var.private_zone_id : local.public_zone_id}" + zone_id = "${var.private_zone_id}" } resource "aws_route53_record" "api_external" { - count = "${var.elb_alias_enabled ? local.public_endpoints_count : 0}" - zone_id = "${local.public_zone_id}" name = "${var.cluster_name}-api.${var.base_domain}" type = "A" @@ -28,8 +21,6 @@ resource "aws_route53_record" "api_external" { } resource "aws_route53_record" "api_internal" { - count = "${var.elb_alias_enabled ? local.private_endpoints_count : 0}" - zone_id = "${var.private_zone_id}" name = "${var.cluster_name}-api.${var.base_domain}" type = "A" diff --git a/data/data/aws/route53/master.tf b/data/data/aws/route53/master.tf deleted file mode 100644 index 0d0d3b880e1..00000000000 --- a/data/data/aws/route53/master.tf +++ /dev/null @@ -1,8 +0,0 @@ -resource "aws_route53_record" "master_nodes" { - count = "${var.elb_alias_enabled ? 0 : var.master_count}" - zone_id = "${data.aws_route53_zone.base.zone_id}" - name = "${var.cluster_name}-master-${count.index}" - type = "A" - ttl = "60" - records = ["${var.master_ip_addresses[count.index]}"] -} diff --git a/data/data/aws/route53/variables.tf b/data/data/aws/route53/variables.tf index e26deecf501..53a7623d155 100644 --- a/data/data/aws/route53/variables.tf +++ b/data/data/aws/route53/variables.tf @@ -50,41 +50,6 @@ variable "extra_tags" { // AWS specific internal zone variables -variable "elb_alias_enabled" { - description = <