From 02c114529d00d10ada8fab9c36f2c67409eff533 Mon Sep 17 00:00:00 2001
From: Stefanie Forrester <sedgar@redhat.com>
Date: Tue, 2 Oct 2018 17:07:00 +0000
Subject: [PATCH] Sanitize S3 bucket name by removing trailing dot

When the user passes the installer a domain name ending in dot `.`,
the S3 bucket name generated by the installer is invalid.
This commit automatically drops the trailing dot to create valid
S3 bucket names.
---
 data/data/aws/main.tf             | 3 ++-
 pkg/types/config/validate.go      | 3 ++-
 pkg/types/config/validate_test.go | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/data/data/aws/main.tf b/data/data/aws/main.tf
index d87c01a810c..b36e5b242cc 100644
--- a/data/data/aws/main.tf
+++ b/data/data/aws/main.tf
@@ -132,7 +132,8 @@ resource "aws_route53_zone" "tectonic_int" {
 }
 
 resource "aws_s3_bucket" "tectonic" {
-  bucket = "${lower(var.tectonic_cluster_name)}.${var.tectonic_base_domain}"
+  # bucket name is cluster_name + base domain, minus the trailing dot, if one exists
+  bucket = "${lower(var.tectonic_cluster_name)}.${join(".",(compact(split(".",var.tectonic_base_domain))))}"
 
   acl = "private"
 
diff --git a/pkg/types/config/validate.go b/pkg/types/config/validate.go
index 03ebd0c4e86..2f99782b90e 100644
--- a/pkg/types/config/validate.go
+++ b/pkg/types/config/validate.go
@@ -248,8 +248,9 @@ func (c *Cluster) validateAWSEndpoints() error {
 // matches the S3 bucket naming rules. Not all rules are checked
 // because Tectonic controls the generation of S3 bucket names, creating
 // buckets of the form: <cluster-name>.<domain-name>
+// If domain-name contains a trailing dot, it's removed from the bucket name.
 func (c *Cluster) validateS3Bucket() error {
-	bucket := fmt.Sprintf("%s.%s", c.Name, c.BaseDomain)
+	bucket := fmt.Sprintf("%s.%s", c.Name, strings.TrimRight(c.BaseDomain, "."))
 	if len(bucket) > maxS3BucketNameLength {
 		return fmt.Errorf("the S3 bucket name %q, generated from the cluster name and base domain, is too long; S3 bucket names must be less than 63 characters; please choose a shorter cluster name or base domain", bucket)
 	}
diff --git a/pkg/types/config/validate_test.go b/pkg/types/config/validate_test.go
index e63194a4729..e335e7296ad 100644
--- a/pkg/types/config/validate_test.go
+++ b/pkg/types/config/validate_test.go
@@ -384,7 +384,7 @@ func TestS3BucketNames(t *testing.T) {
 				Name:       "foo",
 				BaseDomain: "example.com.",
 			},
-			err: true,
+			err: false,
 		},
 		{
 			cluster: Cluster{