From 92116d8e2f1568e0748b993419525869db36dc0e Mon Sep 17 00:00:00 2001 From: Cesar Wong Date: Wed, 29 Jul 2026 18:18:09 +0200 Subject: [PATCH] fix(e2e): make EnsureGlobalPullSecret test informing The EnsureGlobalPullSecret validation is flaky and causing frequent e2e failures. Mark the v2 test as Informing so failures are reported as skips rather than suite failures, and remove the v1 call entirely. Co-Authored-By: Claude Opus 4.6 --- test/e2e/create_cluster_test.go | 1 - test/e2e/v2/tests/hosted_cluster_pull_secret_test.go | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/test/e2e/create_cluster_test.go b/test/e2e/create_cluster_test.go index 75b6daffa829..231542666067 100644 --- a/test/e2e/create_cluster_test.go +++ b/test/e2e/create_cluster_test.go @@ -123,7 +123,6 @@ func TestCreateCluster(t *testing.T) { e2eutil.EnsureKubeAPIServerAllowedCIDRs(t, ctx, mgtClient, guestConfig, hostedCluster) } - e2eutil.EnsureGlobalPullSecret(t, ctx, mgtClient, hostedCluster, globalOpts.AdditionalPullSecretFile) e2eutil.EnsureMetricsForwarderWorking(t, ctx, mgtClient, hostedCluster) // Verify CPO override image if TEST_CPO_OVERRIDE=1 is set diff --git a/test/e2e/v2/tests/hosted_cluster_pull_secret_test.go b/test/e2e/v2/tests/hosted_cluster_pull_secret_test.go index 1601819b407b..f512826809da 100644 --- a/test/e2e/v2/tests/hosted_cluster_pull_secret_test.go +++ b/test/e2e/v2/tests/hosted_cluster_pull_secret_test.go @@ -44,7 +44,7 @@ func RegisterGlobalPullSecretTests(getTestCtx internal.TestContextGetter) { } func EnsureGlobalPullSecretTest(getTestCtx internal.TestContextGetter) { - When("an additional pull secret is created in the hosted cluster", func() { + When("an additional pull secret is created in the hosted cluster", Label("Informing"), func() { It("should propagate it through the global pull secret pipeline and clean up on deletion", func() { tc := getTestCtx() if e2eutil.IsLessThan(e2eutil.Version419) {