Skip to content

Conversation

@muraee
Copy link
Contributor

@muraee muraee commented May 6, 2025

What this PR does / why we need it:
#6073 follow-up to introduce the changes in CPOv2 as well.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2025

@muraee: This pull request references CNTRLPLANE-334 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
#6073 follow-up to introduce the changes in CPOv2 as well.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from enxebre and hasueki May 6, 2025 12:41
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels May 6, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@muraee muraee force-pushed the fix-kas-auth-config branch from 6b3521c to b5d4add Compare May 6, 2025 13:14
@sjenning
Copy link
Contributor

sjenning commented May 6, 2025

Thanks for finding this

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2025
@cwbotbot
Copy link

cwbotbot commented May 6, 2025

Test Results

e2e-aws

e2e-aks

Failed Tests

Total failed tests: 4

  • TestNodePool
  • TestNodePool/HostedCluster0
  • TestNodePool/HostedCluster0/ValidateHostedCluster
  • TestNodePool/HostedCluster0/ValidateHostedCluster/EnsureNoCrashingPods

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cfd918c and 2 for PR HEAD b5d4add in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cfd918c and 2 for PR HEAD b5d4add in total

@openshift-merge-bot openshift-merge-bot bot merged commit cfd918c into openshift:main May 6, 2025
10 of 15 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2025

@muraee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn b5d4add link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants