Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-2231: Remove cloud connection, Set Transit Gateway as default #5293

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HOSTEDCP-2231: Remove cloud connection, Set Transit Gateway as default #5293

wants to merge 1 commit into from
+22 −466

Conversation

aman4433
Copy link

What this PR does / why we need it: This PR updates the PowerVS documentation and code to reflect Transit Gateway as the default networking mode. IBM Cloud has removed support for cloud connection, necessitating this change.

  • Removed references to cloud connection.
  • Updated hypershift powervs commands to use Transit Gateway as the default networking mode.
  • Revised the documentation to provide clear guidance on Transit Gateway usage.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story: Fixes #5062

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This PR was tested locally.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 16, 2024 •
edited by openshift-ci bot
Loading

@aman4433: This pull request references HOSTEDCP-2231 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

What this PR does / why we need it: This PR updates the PowerVS documentation and code to reflect Transit Gateway as the default networking mode. IBM Cloud has removed support for cloud connection, necessitating this change.

  • Removed references to cloud connection.
  • Updated hypershift powervs commands to use Transit Gateway as the default networking mode.
  • Revised the documentation to provide clear guidance on Transit Gateway usage.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story: Fixes #5062

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This PR was tested locally.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the area/cli Indicates the PR includes changes for CLI label Dec 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aman4433
Once this PR has been reviewed and has the lgtm label, please assign jparrill for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/documentation Indicates the PR includes changes for documentation area/testing Indicates the PR includes changes for e2e testing needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed do-not-merge/needs-area labels Dec 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

Hi @aman4433. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dharaneeshvrd
dharaneeshvrd reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@dharaneeshvrd dharaneeshvrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall PR looks good to me.
Before merging this PR, please keep a PR to update the CI jobs in openshift/release as well. Since this is a breaking change for CI job configuration.

docs/content/how-to/powervs/create-cluster-powervs.md Outdated
@@ -48,8 +48,19 @@ where

Running this command will create [infra](create-infra-separately.md) and manifests for the hosted cluster and deploys it.

## Utilizing Power Edge Router(PER) via Transit Gateway
To use IBM Cloud's PER feature via transit gateway, need to pass `--use-power-edge-router` and `--transit-gateway-location $TRANSIT_GATEWAY_LOCATION` flags to create cluster command like below.
## Using Transit Gateway (Default Networking Mode)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this block is not required, let's update the previous block itself with --transit-gateway-location flag and explaining it like other flags would be enough. By keeping it in separate block will confuse the user.

srivastav-abhishek
srivastav-abhishek reviewed Jan 8, 2025
View reviewed changes
docs/content/how-to/powervs/create-cluster-powervs.md Outdated
--pull-secret $PULL_SECRET \
--node-pool-replicas=2 \
--use-power-edge-router \
--transit-gateway-location $TRANSIT_GATEWAY_LOCATION

Read [here](https://cloud.ibm.com/docs/power-iaas?topic=power-iaas-per) to know more about PER and data centers where its deployed currently.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As PER is not supported, we can remove this description for now.

@srivastav-abhishek
Copy link
Contributor

Looks good to me. Just some minor nits !

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 10, 2025
@aman4433 aman4433 mentioned this pull request Jan 10, 2025
Draft
@dharaneeshvrd
Copy link
Member

Please update the docs/content/how-to/powervs/prerequisites-and-env-guide.md's Authorization section since we need an extra permission to do operation on TG.

@aman4433 aman4433 force-pushed the transit-gateway-default branch from 768ef52 to 50e2cdb Compare January 17, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharaneeshvrd dharaneeshvrd dharaneeshvrd left review comments

@srivastav-abhishek srivastav-abhishek srivastav-abhishek left review comments

@csrwng csrwng Awaiting requested review from csrwng

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees
No one assigned
Labels
area/cli Indicates the PR includes changes for CLI area/documentation Indicates the PR includes changes for documentation area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use transit-gateway by default instead of cloud connection
5 participants
@aman4433 @openshift-ci-robot @srivastav-abhishek @dharaneeshvrd @openshift-merge-robot