Skip to content

[release-4.14] OCPBUGS-19921: pkg/clusterconditions/cache: Avoid panic on all-fresh-cache evaluation #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-ci merged 1 commit into from
Oct 8, 2023
Merged

[release-4.14] OCPBUGS-19921: pkg/clusterconditions/cache: Avoid panic on all-fresh-cache evaluation #976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/clusterconditions/cache/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ func (c *Cache) Match(ctx context.Context, condition *configv1.ClusterCondition)
detail = fmt.Sprintf(" (last evaluated on %s)", thiefResult.When)
}
klog.V(2).Infof("%s is the most stale cached cluster-condition match entry, but it is too fresh%s. However, we don't have a cached evaluation for %s, so attempt to evaluate that now.", thiefKey, detail, key)
thiefKey = key
targetCondition = condition
}

// if we ended up stealing this Match call, log that, to make contention more clear
Expand Down