From addc956fc01977baa115d7bc3fe8fee9fcb9f0e0 Mon Sep 17 00:00:00 2001 From: Clayton Coleman Date: Tue, 22 Oct 2019 13:42:39 -0400 Subject: [PATCH] payload: Task graph might lose some work if cancelled A context cancel is always an error for the task graph --- pkg/payload/task_graph.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkg/payload/task_graph.go b/pkg/payload/task_graph.go index 4976182842..c0106a4eb7 100644 --- a/pkg/payload/task_graph.go +++ b/pkg/payload/task_graph.go @@ -612,5 +612,9 @@ func RunGraph(ctx context.Context, graph *TaskGraph, maxParallelism int, fn func if len(errs) > 0 { return errs } + // if the context was cancelled, we may have unfinished work + if err := ctx.Err(); err != nil { + return []error{err} + } return nil }