From d544606e448951f1514ded41d1fe92880ed782d9 Mon Sep 17 00:00:00 2001
From: "W. Trevor King" <wking@tremily.us>
Date: Wed, 17 Dec 2025 16:54:10 -0800
Subject: [PATCH] pkg/payload/precondition/clusterversion/gianthop: Allow
 updates to 5.0

Not sure yet if OCP 5.0 will be a thing, but to help folks feeling out
that space just in case [1], relax the current giant-hop guard in 4.22
to allow updates to 5.0.  I'm special-casing 5.0 (e.g. no allowing 4
-> 6 or 4 -> 5.1) to make the smallest possible change at this
early-testing stage.

[1]: https://access.redhat.com/articles/7134648
---
 .../precondition/clusterversion/gianthop.go   | 10 ++++++
 .../clusterversion/gianthop_test.go           | 32 +++++++++++++++++++
 2 files changed, 42 insertions(+)

diff --git a/pkg/payload/precondition/clusterversion/gianthop.go b/pkg/payload/precondition/clusterversion/gianthop.go
index 97727e78b5..55bba6e9b7 100644
--- a/pkg/payload/precondition/clusterversion/gianthop.go
+++ b/pkg/payload/precondition/clusterversion/gianthop.go
@@ -66,6 +66,16 @@ func (p *GiantHop) Run(ctx context.Context, releaseContext precondition.ReleaseC
 	}
 
 	if targetVersion.Major > currentVersion.Major {
+		if targetVersion.Major == 5 && currentVersion.Major == 4 { // TODO: temporary access from v4 to 5.0, to be reverted once we are in v5 development
+			if targetVersion.Minor == 0 {
+				return nil
+			}
+			return &precondition.Error{
+				Reason:  "MajorVersionUpdate",
+				Message: fmt.Sprintf("%s has a larger major version than the current target %s (%d > %d), and only updates within the current major version or to 5.0 are supported.", targetVersion, currentVersion, targetVersion.Major, currentVersion.Major),
+				Name:    p.Name(),
+			}
+		}
 		return &precondition.Error{
 			Reason:  "MajorVersionUpdate",
 			Message: fmt.Sprintf("%s has a larger major version than the current target %s (%d > %d), and only updates within the current major version are supported.", targetVersion, currentVersion, targetVersion.Major, currentVersion.Major),
diff --git a/pkg/payload/precondition/clusterversion/gianthop_test.go b/pkg/payload/precondition/clusterversion/gianthop_test.go
index 4e7b6fda71..cf7cd7664e 100644
--- a/pkg/payload/precondition/clusterversion/gianthop_test.go
+++ b/pkg/payload/precondition/clusterversion/gianthop_test.go
@@ -64,6 +64,38 @@ func TestGiantHopRun(t *testing.T) {
 			},
 			expected: "2.0.0 has a larger major version than the current target 1.0.0 (2 > 1), and only updates within the current major version are supported.",
 		},
+		{
+			name: "major version is 5.0",
+			clusterVersion: configv1.ClusterVersion{
+				Spec: configv1.ClusterVersionSpec{
+					DesiredUpdate: &configv1.Update{
+						Version: "5.0.0",
+					},
+				},
+				Status: configv1.ClusterVersionStatus{
+					Desired: configv1.Release{
+						Version: "4.0.0",
+					},
+				},
+			},
+			expected: "",
+		},
+		{
+			name: "major version is 5.1",
+			clusterVersion: configv1.ClusterVersion{
+				Spec: configv1.ClusterVersionSpec{
+					DesiredUpdate: &configv1.Update{
+						Version: "5.1.0",
+					},
+				},
+				Status: configv1.ClusterVersionStatus{
+					Desired: configv1.Release{
+						Version: "4.0.0",
+					},
+				},
+			},
+			expected: "5.1.0 has a larger major version than the current target 4.0.0 (5 > 4), and only updates within the current major version or to 5.0 are supported.",
+		},
 		{
 			name: "two minor versions",
 			clusterVersion: configv1.ClusterVersion{