Skip to content

WIP: fix: openshift-node-performance now has a default platform agnostic fallback #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP: fix: openshift-node-performance now has a default platform agnostic fallback #1423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d35826
fix: openshift-node-performance now has a default platform agnostic f…
prb112 Nov 3, 2025
7e80e0e
resolve issues with ppc64le mapping
prb112 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/performanceprofile/tuned/openshift-node-performance
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ summary=Openshift node optimized for deterministic performance at the cost of in
# openshift-node,cpu-partitioning
# openshift-node,cpu-partitioning,openshift-node-performance-rt-<PerformanceProfile name>
include=openshift-node,cpu-partitioning${f:regex_search_ternary:${f:exec:uname:-r}:rt:,openshift-node-performance-rt-{{.PerformanceProfileName}}:};
openshift-node-performance-${f:lscpu_check:Vendor ID\:\s*GenuineIntel:intel:Vendor ID\:\s*AuthenticAMD:amd:Architecture\:\s*aarch64:arm}-${f:lscpu_check:Architecture\:\s*x86_64:x86:Architecture\:\s*aarch64:aarch64}-{{.PerformanceProfileName}}
openshift-node-performance-${f:lscpu_check:Vendor ID\:\s*GenuineIntel:intel:Vendor ID\:\s*AuthenticAMD:amd:Architecture\:\s*aarch64:arm:Architecture\:\s*ppc64le:ibm}-${f:lscpu_check:Architecture\:\s*x86_64:x86:Architecture\:\s*aarch64:aarch64:Architecture\:\s*ppc64le:ppc64le}-{{.PerformanceProfileName}}

# Inheritance of base profiles legend:
# cpu-partitioning -> network-latency -> latency-performance
Expand Down
2 changes: 2 additions & 0 deletions assets/performanceprofile/tuned/openshift-node-performance--
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[main]
summary=Platform agnostic include file
6 changes: 6 additions & 0 deletions assets/performanceprofile/tuned/openshift-node-performance-ibm-ppc64le
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[main]
summary=Platform specific tuning for IBM POWER (ppc64le)

[bootloader]
# No specific IOMMU settings for POWER
# No pstate args for POWER
2 changes: 2 additions & 0 deletions pkg/performanceprofile/controller/performanceprofile/components/consts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ const (
ProfileNameArmAarch64 = "openshift-node-performance-arm-aarch64"
// ProfileNameIntelX86 defines the Intel X86 specific tuning parameters
ProfileNameIntelX86 = "openshift-node-performance-intel-x86"
// ProfileNameIbmPpc64le defines the IBM POWER ppc64le specific tuning parameters
ProfileNameIbmPpc64le = "openshift-node-performance--ppc64le"
)

const (
Expand Down
10 changes: 10 additions & 0 deletions pkg/performanceprofile/controller/performanceprofile/components/tuned/tuned.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,12 @@ func NewNodePerformance(profile *performancev2.PerformanceProfile) (*tunedv1.Tun
}
IntelX86ProfileName := components.GetComponentName(profile.Name, components.ProfileNameIntelX86)

IbmPpc64leProfileData, err := getProfileData(filepath.Join("tuned", components.ProfileNameIbmPpc64le), templateArgs)
if err != nil {
return nil, err
}
IbmPpc64leProfileName := components.GetComponentName(profile.Name, components.ProfileNameIbmPpc64le)

profiles := []tunedv1.TunedProfile{
{
Name: &name,
Expand All @@ -261,6 +267,10 @@ func NewNodePerformance(profile *performancev2.PerformanceProfile) (*tunedv1.Tun
Name: &IntelX86ProfileName,
Data: &IntelX86ProfileData,
},
{
Name: &IbmPpc64leProfileName,
Data: &IbmPpc64leProfileData,
},
}

priority := uint64(20)
Expand Down