WIP: Use the new IRQBALANCE_BANNED_CPULIST variable #1227
Conversation
The IRQBALANCE_BANNED_CPUS variable is deprecated and will not be used anymore in the near future. The newer IRQBALANCE_BANNED_CPULIST variable is already supported by irqbalanced (https://github.com/Irqbalance/irqbalance/blob/v1.9.0/cputree.c#L135) and should be used. This must be merged together with cri-o/cri-o#8783 Signed-off-by: Martin Sivak <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MarSik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cc jmencak |
jmencak
left a comment
jmencak
left a comment
There was a problem hiding this comment.
- missing "make render-sync"
- Unit tests are failing with this, they'll likely need to be adjusted.
|
|
||
| # CPU numbers which have their corresponding bits set to one in this mask | ||
| # will not have any irq's assigned to them on rebalance. | ||
| # so zero means all cpus are participating in load balancing. |
There was a problem hiding this comment.
Comment needs to be adjusted, there's no longer 0. We have empty string.
There was a problem hiding this comment.
In fact, we will need to change it to a "-", because an empty string inherits from nohz_full.
Tal-or
left a comment
Tal-or
left a comment
There was a problem hiding this comment.
what should go first? this one or cri-o/cri-o#8931
|
@MarSik: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
/remove-lifecycle rotten |
openshift-ci
bot
removed
the
lifecycle/rotten
|
/hold waiting for cri-o/cri-o#8931 |
openshift-ci
bot
added
the
do-not-merge/hold
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
openshift-ci
bot
removed
the
lifecycle/stale
4 participants
Use the new IRQBALANCE_BANNED_CPULIST variable
The IRQBALANCE_BANNED_CPUS variable is deprecated and will not
be used anymore in the near future.
The newer IRQBALANCE_BANNED_CPULIST variable is already supported
by irqbalanced (https://github.com/Irqbalance/irqbalance/blob/v1.9.0/cputree.c#L135)
and should be used.
This must be merged together with cri-o/cri-o#8783