Skip to content

Commit 23a896a

Browse files
Merge pull request #2608 from machine424/ffft
OCPBUGS-57184: chore(alerts): adjust PrometheusPossibleNarrowSelectors description and add link to to-be-added runbook
2 parents ca4b9ee + f256ef7 commit 23a896a

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

assets/cluster-monitoring-operator/prometheus-rule.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,10 @@ spec:
3333
- alert: PrometheusPossibleNarrowSelectors
3434
annotations:
3535
description: Queries or/and relabel configs on Prometheus/Thanos {{$labels.namespace}}/{{$labels.pod}} could be too restrictive.
36+
runbook_url: https://github.com/openshift/runbooks/blob/master/alerts/cluster-monitoring-operator/PrometheusPossibleNarrowSelectors.md
3637
summary: |
3738
Some queries or/and relabel configs with selectors on the values of the "le" label of classic histograms or/and the "quantile" label of summaries
38-
may not take into account that values could also be floats, they may need to be adjusted. If assistance is needed, please let us know at https://issues.redhat.com/browse/MON-4129.
39+
may not take into account that values could also be floats, they may need to be adjusted.
3940
expr: increase(prometheus_narrow_selectors_count{job=~"prometheus-k8s|prometheus-user-workload|thanos-querier|thanos-ruler"}[5m]) > 0
4041
for: 15m
4142
labels:

assets/prometheus-k8s/prometheus-rule.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ spec:
3939
- alert: PrometheusKubernetesListWatchFailures
4040
annotations:
4141
description: Kubernetes service discovery of Prometheus {{$labels.namespace}}/{{$labels.pod}} is experiencing {{ printf "%.0f" $value }} failures with LIST/WATCH requests to the Kubernetes API in the last 5 minutes.
42+
runbook_url: https://github.com/openshift/runbooks/blob/master/alerts/cluster-monitoring-operator/PrometheusKubernetesListWatchFailures.md
4243
summary: Requests in Kubernetes SD are failing.
4344
expr: |
4445
increase(prometheus_sd_kubernetes_failures_total{job=~"prometheus-k8s|prometheus-user-workload"}[5m]) > 0

jsonnet/rules.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ function(params) {
3535
description: 'Queries or/and relabel configs on Prometheus/Thanos {{$labels.namespace}}/{{$labels.pod}} could be too restrictive.',
3636
summary: |||
3737
Some queries or/and relabel configs with selectors on the values of the "le" label of classic histograms or/and the "quantile" label of summaries
38-
may not take into account that values could also be floats, they may need to be adjusted. If assistance is needed, please let us know at https://issues.redhat.com/browse/MON-4129.
38+
may not take into account that values could also be floats, they may need to be adjusted.
3939
|||,
4040
},
4141
labels: {

jsonnet/utils/sanitize-rules.libsonnet

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -517,6 +517,8 @@ local includeRunbooks = {
517517
NodeClockNotSynchronising: openShiftRunbookCMO('NodeClockNotSynchronising.md'),
518518
PrometheusOperatorRejectedResources: openShiftRunbookCMO('PrometheusOperatorRejectedResources.md'),
519519
PrometheusDuplicateTimestamps: openShiftRunbookCMO('PrometheusDuplicateTimestamps.md'),
520+
PrometheusPossibleNarrowSelectors: openShiftRunbookCMO('PrometheusPossibleNarrowSelectors.md'),
521+
PrometheusKubernetesListWatchFailures: openShiftRunbookCMO('PrometheusKubernetesListWatchFailures.md'),
520522
PrometheusRuleFailures: openShiftRunbookCMO('PrometheusRuleFailures.md'),
521523
PrometheusRemoteStorageFailures: openShiftRunbookCMO('PrometheusRemoteStorageFailures.md'),
522524
PrometheusScrapeBodySizeLimitHit: openShiftRunbookCMO('PrometheusScrapeBodySizeLimitHit.md'),

0 commit comments

Comments
 (0)