OCPBUGS-45895: allow reconciling existing Secrets

Until now, CMO did not reconcile existing secrets, even if their data
changed. This changes that behavior.

Signed-off-by: Pranshu Srivastava <[email protected]>

Author: rexagod

pkg/tasks/alertmanager.go

@@ -101,7 +101,7 @@ func (t *AlertmanagerTask) create(ctx context.Context) error {
 		return fmt.Errorf("initializing Alertmanager RBAC proxy Secret failed: %w", err)
 	}
 
-	err = t.client.CreateIfNotExistSecret(ctx, rs)
+	err = t.client.CreateOrUpdateSecret(ctx, rs)
 	if err != nil {
 		return fmt.Errorf("creating Alertmanager RBAC proxy Secret failed: %w", err)
 	}
@@ -111,7 +111,7 @@ func (t *AlertmanagerTask) create(ctx context.Context) error {
 		return fmt.Errorf("initializing Alertmanager RBAC proxy metric Secret failed: %w", err)
 	}
 
-	err = t.client.CreateIfNotExistSecret(ctx, rsm)
+	err = t.client.CreateOrUpdateSecret(ctx, rsm)
 	if err != nil {
 		return fmt.Errorf("creating Alertmanager RBAC proxy metric Secret failed: %w", err)
 	}
@@ -163,7 +163,7 @@ func (t *AlertmanagerTask) create(ctx context.Context) error {
 		return fmt.Errorf("initializing Alertmanager proxy web Secret failed: %w", err)
 	}
 
-	err = t.client.CreateIfNotExistSecret(ctx, ps)
+	err = t.client.CreateOrUpdateSecret(ctx, ps)
 	if err != nil {
 		return fmt.Errorf("creating Alertmanager proxy web Secret failed: %w", err)
 	}

pkg/tasks/alertmanager_user_workload.go

@@ -80,7 +80,7 @@ func (t *AlertmanagerUserWorkloadTask) create(ctx context.Context) error {
 		return fmt.Errorf("initializing Alertmanager User Workload RBAC proxy Secret failed: %w", err)
 	}
 
-	err = t.client.CreateIfNotExistSecret(ctx, s)
+	err = t.client.CreateOrUpdateSecret(ctx, s)
 	if err != nil {
 		return fmt.Errorf("creating Alertmanager User Workload RBAC proxy Secret failed: %w", err)
 	}
@@ -90,7 +90,7 @@ func (t *AlertmanagerUserWorkloadTask) create(ctx context.Context) error {
 		return fmt.Errorf("initializing Alertmanager User Workload RBAC proxy tenancy Secret failed: %w", err)
 	}
 
-	err = t.client.CreateIfNotExistSecret(ctx, s)
+	err = t.client.CreateOrUpdateSecret(ctx, s)
 	if err != nil {
 		return fmt.Errorf("creating Alertmanager User Workload RBAC proxy tenancy Secret failed: %w", err)
 	}
@@ -100,7 +100,7 @@ func (t *AlertmanagerUserWorkloadTask) create(ctx context.Context) error {
 		return fmt.Errorf("initializing Alertmanager User Workload RBAC proxy metric Secret failed: %w", err)
 	}
 
-	err = t.client.CreateIfNotExistSecret(ctx, rsm)
+	err = t.client.CreateOrUpdateSecret(ctx, rsm)
 	if err != nil {
 		return fmt.Errorf("creating Alertmanager User Workload RBAC proxy metric Secret failed: %w", err)
 	}

pkg/tasks/kubestatemetrics.go

@@ -70,7 +70,7 @@ func (t *KubeStateMetricsTask) Run(ctx context.Context) error {
 		return fmt.Errorf("initializing kube-state-metrics RBAC proxy Secret failed: %w", err)
 	}
 
-	err = t.client.CreateIfNotExistSecret(ctx, rs)
+	err = t.client.CreateOrUpdateSecret(ctx, rs)
 	if err != nil {
 		return fmt.Errorf("creating kube-state-metrics RBAC proxy Secret failed: %w", err)
 	}

pkg/tasks/nodeexporter.go

@@ -80,7 +80,7 @@ func (t *NodeExporterTask) Run(ctx context.Context) error {
 		return fmt.Errorf("intializing node-exporter rbac proxy secret failed: %w", err)
 	}
 
-	err = t.client.CreateIfNotExistSecret(ctx, nes)
+	err = t.client.CreateOrUpdateSecret(ctx, nes)
 	if err != nil {
 		return fmt.Errorf("creating node-exporter rbac proxy secret failed: %w", err)
 	}

pkg/tasks/openshiftstatemetrics.go

@@ -80,7 +80,7 @@ func (t *OpenShiftStateMetricsTask) Run(ctx context.Context) error {
 		return fmt.Errorf("initializing openshift-state-metrics RBAC proxy Secret failed: %w", err)
 	}
 
-	err = t.client.CreateIfNotExistSecret(ctx, rs)
+	err = t.client.CreateOrUpdateSecret(ctx, rs)
 	if err != nil {
 		return fmt.Errorf("creating openshift-state-metrics RBAC proxy Secret failed: %w", err)
 	}

pkg/tasks/prometheusoperator.go

@@ -85,7 +85,7 @@ func (t *PrometheusOperatorTask) Run(ctx context.Context) error {
 		return fmt.Errorf("initializing Prometheus Operator RBAC proxy Secret failed: %w", err)
 	}
 
-	err = t.client.CreateIfNotExistSecret(ctx, rs)
+	err = t.client.CreateOrUpdateSecret(ctx, rs)
 	if err != nil {
 		return fmt.Errorf("creating Prometheus Operator RBAC proxy Secret failed: %w", err)
 	}

pkg/tasks/thanos_querier.go

@@ -73,7 +73,7 @@ func (t *ThanosQuerierTask) Run(ctx context.Context) error {
 		return fmt.Errorf("initializing Thanos Querier RBAC proxy Secret failed: %w", err)
 	}
 
-	err = t.client.CreateIfNotExistSecret(ctx, rs)
+	err = t.client.CreateOrUpdateSecret(ctx, rs)
 	if err != nil {
 		return fmt.Errorf("creating Thanos Querier RBAC proxy Secret failed: %w", err)
 	}
@@ -83,7 +83,7 @@ func (t *ThanosQuerierTask) Run(ctx context.Context) error {
 		return fmt.Errorf("initializing Thanos Querier RBAC proxy rules Secret failed: %w", err)
 	}
 
-	err = t.client.CreateIfNotExistSecret(ctx, rs)
+	err = t.client.CreateOrUpdateSecret(ctx, rs)
 	if err != nil {
 		return fmt.Errorf("creating Thanos Querier RBAC proxy rules Secret failed: %w", err)
 	}
@@ -93,7 +93,7 @@ func (t *ThanosQuerierTask) Run(ctx context.Context) error {
 		return fmt.Errorf("initializing Thanos Querier RBAC proxy metrics Secret failed: %w", err)
 	}
 
-	err = t.client.CreateIfNotExistSecret(ctx, rs)
+	err = t.client.CreateOrUpdateSecret(ctx, rs)
 	if err != nil {
 		return fmt.Errorf("creating Thanos Querier RBAC proxy metrics Secret failed: %w", err)
 	}