Skip to content

kube-scheduler: config authnz settings#89

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
s-urbaniak:authnz
Apr 8, 2019
Merged

kube-scheduler: config authnz settings#89
openshift-merge-robot merged 1 commit into
openshift:masterfrom
s-urbaniak:authnz

Conversation

@s-urbaniak

@s-urbaniak s-urbaniak commented Apr 8, 2019

Copy link
Copy Markdown
Contributor

/cc @sttts

@openshift-ci-robot openshift-ci-robot requested a review from sttts April 8, 2019 14:13
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2019
@sttts

sttts commented Apr 8, 2019

Copy link
Copy Markdown
Contributor

/approve
lgtm

Giving @ravisantoshgudimetla a chance to look at it.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2019
@s-urbaniak

s-urbaniak commented Apr 8, 2019

Copy link
Copy Markdown
Contributor Author

similar as openshift/cluster-kube-controller-manager-operator#213,
this, and the controller-manager is currently blocking e2e tests in cluster monitoring (and probably anything that wants to connect to the secure port of controller-manager

@s-urbaniak s-urbaniak mentioned this pull request Apr 8, 2019
Closed
@brancz

brancz commented Apr 8, 2019

Copy link
Copy Markdown

/retest

ravisantoshgudimetla
ravisantoshgudimetla approved these changes Apr 8, 2019
View reviewed changes

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @s-urbaniak for this PR.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2019
@ravisantoshgudimetla

ravisantoshgudimetla commented Apr 8, 2019

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci-robot

openshift-ci-robot commented Apr 8, 2019

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravisantoshgudimetla, s-urbaniak, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ravisantoshgudimetla,sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 299320e into openshift:master Apr 8, 2019
@s-urbaniak s-urbaniak deleted the authnz branch April 9, 2019 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sttts sttts Awaiting requested review from sttts

1 more reviewer

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ravisantoshgudimetla ravisantoshgudimetla

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@s-urbaniak @sttts @brancz @ravisantoshgudimetla @openshift-ci-robot @openshift-merge-robot