CNTRLPLANE-5: Wire a feature-gates config observer for oauth-apiserver. #773
Conversation
|
Depends on openshift/oauth-apiserver#136. |
|
@bertinatto: This PR was included in a payload test run from openshift/api#2235
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9eea4420-5cbe-11f0-80a0-5f9b4653dd2f-0 |
|
@benluddy: This PR was included in a payload test run from openshift/api#2235
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e0f51ac0-5dc7-11f0-9045-c1bd2a98a1cb-0 |
|
@benluddy: This PR was included in a payload test run from openshift/api#2235
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/04872da0-5e83-11f0-9267-86cff4c3f599-0 |
|
@benluddy: This PR was included in a payload test run from openshift/api#2235
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5da717a0-6276-11f0-81c1-8588197ced8c-0 |
|
@bertinatto: This PR was included in a payload test run from openshift/api#2235
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/859f6210-62f5-11f0-925f-fb8a3fefd6e8-0 |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-techpreview-serial openshift/oauth-apiserver#136 |
|
@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b9a734e0-634d-11f0-97ae-3d098bea2ce2-0 |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retitle CNTRLPLANE-5: Wire a feature-gates config observer for oauth-apiserver. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@benluddy: This pull request references CNTRLPLANE-5 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
1 similar comment
|
/retest |
|
/cc @ibihim |
pkg/operator/configobservation/configobservercontroller/config_observer_controller.go
Outdated
Show resolved
Hide resolved
benluddy
force-pushed
the
oauth-apiserver-feature-gate-configobserver
branch
from
933e48a to
ed118a7
Compare
|
/lgtm |
|
/retest-required |
The diff is hard to understand but this is the behavior difference tucked in there: Management: mutation: Update-Authentication.v1.operator.openshift.io/cluster[], fieldManager=, controllerInstanceName=, rhs[0]: body diff: []uint8( """ ... // 16 identical lines - //127\.0\.0\.1(:|$) - //localhost(:|$) + feature-gates: [] tls-cipher-suites: - TLS_AES_128_GCM_SHA256 ... // 11 identical lines """ )
benluddy
force-pushed
the
oauth-apiserver-feature-gate-configobserver
branch
from
ed118a7 to
dffdb12
Compare
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
@benluddy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
/assign @liouk |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, ibihim, liouk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit cc54807
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-authentication-operator |
5 participants
No description provided.