From adbde36a3e6605583250504f0d1c67118a87dd0b Mon Sep 17 00:00:00 2001 From: Prashanth Sundararaman Date: Wed, 2 Dec 2020 19:09:53 -0500 Subject: [PATCH] Use SPICE graphics only for x86_64 SPICE Graphics is supported for x86_64 and aarch64. But it looks like the downstream RHEL qemu only enables SPICE graphics for x86_64 --- pkg/cloud/libvirt/client/domain.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/pkg/cloud/libvirt/client/domain.go b/pkg/cloud/libvirt/client/domain.go index 4c7d65618..f5386f44b 100644 --- a/pkg/cloud/libvirt/client/domain.go +++ b/pkg/cloud/libvirt/client/domain.go @@ -106,10 +106,8 @@ func newDevicesDef(virConn *libvirt.Connect) *libvirtxml.DomainDeviceList { if err != nil { glog.Errorf("Error retrieving host architecture: %s", err) } - // Both "s390" and "s390x" are linux kernel architectures for Linux on IBM z Systems, and they are for 31-bit and 64-bit respectively. - // Graphics/Spice isn't supported on s390/s390x platform. - // Same case for PowerPC systems as well - if !strings.HasPrefix(arch, "s390") && !strings.HasPrefix(arch, "ppc64") { + // Currently SPICE is supported on x86_64 and aarch64. But it is only enabled in RHEL qemu for x86_64. + if arch == "x86_64" { domainList.Graphics = []libvirtxml.DomainGraphic{ { Spice: &libvirtxml.DomainGraphicSpice{