-
Notifications
You must be signed in to change notification settings - Fork 25
OCPCLOUD-3276,OCPBUGS-76344,OCPBUGS-69888,OCPBUGS-78289: Merge https://github.com/kubernetes/cloud-provider-aws:master (ea961d6) into main #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3739e68
d1c7c02
54ac0d6
742c08c
8d3200f
1243690
32e84a3
9d1154c
af797b6
b6c9d76
add3c4d
b3040e8
ea961d6
06fd63f
6457ff3
b70e407
6e96d33
b18d390
fe5737d
1e4dcfa
b0815a3
b252e78
b9463cc
7b7e0a5
5fc1583
9af4661
2677999
920780c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| build_root_image: | ||
| name: release | ||
| namespace: openshift | ||
| tag: rhel-9-release-golang-1.24-openshift-4.22 | ||
| tag: rhel-9-release-golang-1.25-openshift-4.22 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,3 @@ e2e.test | |
| .idea/ | ||
| **/*.swp | ||
| .DS_Store | ||
|
|
||
| # OpenShift hack | ||
| /aws-cloud-controller-manager-tests-ext | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| defaultBaseImage: registry.k8s.io/build-image/go-runner:v2.4.0-go1.24.9-bookworm.0 | ||
| defaultBaseImage: registry.k8s.io/build-image/go-runner:v2.4.0-go1.25.5-bookworm.0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,16 @@ | ||
| FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.22 AS builder | ||
| FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.25-openshift-4.22 AS builder | ||
|
|
||
| # | ||
| # CCM binary builder | ||
| # | ||
| WORKDIR /build | ||
| COPY . . | ||
| RUN GO111MODULE=on CGO_ENABLED=0 GOOS=${GOOS} GOPROXY=${GOPROXY} go build \ | ||
| -ldflags="-w -s -X 'main.version=${VERSION}'" \ | ||
| -o=aws-cloud-controller-manager \ | ||
| cmd/aws-cloud-controller-manager/main.go | ||
|
|
||
| # | ||
| # OpenShift Tests Extension binary builder | ||
| # | ||
| RUN pushd tests/aws-cloud-controller-manager-tests-ext && \ | ||
| GO111MODULE=on CGO_ENABLED=0 GOOS=${GOOS} GOPROXY=${GOPROXY} go build \ | ||
| -trimpath \ | ||
| -ldflags="-w -s -X 'main.version=${VERSION}'" \ | ||
| -o=/build/aws-cloud-controller-manager-tests-ext . && \ | ||
| gzip /build/aws-cloud-controller-manager-tests-ext | ||
|
|
||
| # | ||
| # Main stage | ||
| # | ||
| FROM registry.ci.openshift.org/ocp/4.22:base-rhel9 | ||
|
|
||
| LABEL description="AWS Cloud Controller Manager" | ||
|
|
||
| COPY --from=builder /build/aws-cloud-controller-manager /bin/aws-cloud-controller-manager | ||
| COPY --from=builder /build/aws-cloud-controller-manager-tests-ext.gz /bin/aws-cloud-controller-manager-tests-ext.gz | ||
|
|
||
| ENTRYPOINT [ "/bin/aws-cloud-controller-manager" ] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,51 @@ | ||
| module k8s.io/cloud-provider-aws | ||
|
|
||
| go 1.24.0 | ||
| go 1.25.0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result: The latest stable Go release is Go 1.26.1, released on March 5, 2026. [1] Sources: 🌐 Web query:
💡 Result:
Sources: Consider updating to Go 1.25.8 instead of 1.25.0. Go 1.25.0 is a valid, production-stable release. However, as of March 2026, Go 1.25.8 is available and includes accumulated bug and security fixes. Use the latest 1.25 patch release for production deployments. 🤖 Prompt for AI Agents |
||
|
|
||
| require ( | ||
| github.com/Pallinder/go-randomdata v1.2.0 | ||
| github.com/aws/aws-sdk-go-v2 v1.38.3 | ||
| github.com/aws/aws-sdk-go-v2 v1.41.1 | ||
| github.com/aws/aws-sdk-go-v2/config v1.29.14 | ||
| github.com/aws/aws-sdk-go-v2/service/autoscaling v1.53.3 | ||
| github.com/aws/aws-sdk-go-v2/service/ecr v1.36.2 | ||
| github.com/aws/aws-sdk-go-v2/service/ecr v1.55.1 | ||
| github.com/aws/aws-sdk-go-v2/service/ecrpublic v1.27.2 | ||
| github.com/aws/aws-sdk-go-v2/service/elasticloadbalancing v1.29.3 | ||
| github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2 v1.45.2 | ||
| github.com/aws/aws-sdk-go-v2/service/kms v1.41.0 | ||
| github.com/mitchellh/hashstructure/v2 v2.0.2 | ||
| github.com/onsi/ginkgo/v2 v2.23.0 | ||
| github.com/onsi/gomega v1.36.2 | ||
| github.com/onsi/ginkgo/v2 v2.27.2 | ||
| github.com/onsi/gomega v1.38.2 | ||
| github.com/samber/lo v1.49.1 | ||
| github.com/spf13/cobra v1.9.1 | ||
| github.com/spf13/pflag v1.0.6 | ||
| github.com/stretchr/testify v1.10.0 | ||
| github.com/spf13/cobra v1.10.0 | ||
| github.com/spf13/pflag v1.0.9 | ||
| github.com/stretchr/testify v1.11.1 | ||
| golang.org/x/time v0.11.0 | ||
| gopkg.in/gcfg.v1 v1.2.3 | ||
| k8s.io/api v0.34.0 | ||
| k8s.io/apimachinery v0.34.0 | ||
| k8s.io/client-go v0.34.0 | ||
| k8s.io/cloud-provider v0.34.0 | ||
| k8s.io/code-generator v0.34.0 | ||
| k8s.io/component-base v0.34.0 | ||
| k8s.io/controller-manager v0.34.0 | ||
| k8s.io/api v0.35.0 | ||
| k8s.io/apimachinery v0.35.0 | ||
| k8s.io/client-go v0.35.0 | ||
| k8s.io/cloud-provider v0.35.0 | ||
| k8s.io/code-generator v0.35.0 | ||
| k8s.io/component-base v0.35.0 | ||
| k8s.io/controller-manager v0.35.0 | ||
| k8s.io/klog/v2 v2.130.1 | ||
| k8s.io/kubelet v0.34.0 | ||
| k8s.io/utils v0.0.0-20250604170112-4c0f3b243397 | ||
| k8s.io/kubelet v0.35.0 | ||
| k8s.io/utils v0.0.0-20251002143259-bc988d571ff4 | ||
| sigs.k8s.io/controller-runtime v0.20.3 | ||
| ) | ||
|
|
||
| require ( | ||
| cel.dev/expr v0.24.0 // indirect | ||
| github.com/Masterminds/semver/v3 v3.4.0 // indirect | ||
| github.com/go-task/slim-sprig/v3 v3.0.0 // indirect | ||
| github.com/google/btree v1.1.3 // indirect | ||
| github.com/google/pprof v0.0.0-20241210010833-40e02aabc2ad // indirect | ||
| github.com/google/pprof v0.0.0-20250403155104-27863c87afa6 // indirect | ||
| github.com/kylelemons/godebug v1.1.0 // indirect | ||
| github.com/prometheus/client_golang v1.22.0 // indirect | ||
| go.opentelemetry.io/auto/sdk v1.1.0 // indirect | ||
| go.yaml.in/yaml/v2 v2.4.2 // indirect | ||
| github.com/prometheus/client_golang v1.23.2 // indirect | ||
| go.opentelemetry.io/auto/sdk v1.2.1 // indirect | ||
| go.yaml.in/yaml/v2 v2.4.3 // indirect | ||
| go.yaml.in/yaml/v3 v3.0.4 // indirect | ||
| gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect | ||
| gopkg.in/evanphx/json-patch.v4 v4.13.0 // indirect | ||
| gopkg.in/inf.v0 v0.9.1 // indirect | ||
| gopkg.in/natefinch/lumberjack.v2 v2.2.1 // indirect | ||
| gopkg.in/warnings.v0 v0.1.2 // indirect | ||
|
|
@@ -59,16 +60,16 @@ require ( | |
| github.com/antlr4-go/antlr/v4 v4.13.0 // indirect | ||
| github.com/aws/aws-sdk-go-v2/credentials v1.17.67 | ||
| github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.31 | ||
| github.com/aws/aws-sdk-go-v2/internal/configsources v1.4.6 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.7.6 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/configsources v1.4.17 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.7.17 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/ini v1.8.3 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/ec2 v1.249.0 | ||
| github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.13.1 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.6 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/sso v1.25.3 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/ssooidc v1.30.1 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/sts v1.33.19 | ||
| github.com/aws/smithy-go v1.23.0 | ||
| github.com/aws/smithy-go v1.24.0 | ||
| github.com/beorn7/perks v1.0.1 // indirect | ||
| github.com/blang/semver/v4 v4.0.0 // indirect | ||
| github.com/cenkalti/backoff/v4 v4.3.0 // indirect | ||
|
|
@@ -80,7 +81,7 @@ require ( | |
| github.com/felixge/httpsnoop v1.0.4 // indirect | ||
| github.com/fsnotify/fsnotify v1.9.0 // indirect | ||
| github.com/fxamacker/cbor/v2 v2.9.0 // indirect | ||
| github.com/go-logr/logr v1.4.2 // indirect | ||
| github.com/go-logr/logr v1.4.3 // indirect | ||
| github.com/go-logr/stdr v1.2.2 // indirect | ||
| github.com/go-openapi/jsonpointer v0.21.0 // indirect | ||
| github.com/go-openapi/jsonreference v0.20.2 // indirect | ||
|
|
@@ -94,56 +95,54 @@ require ( | |
| github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0 // indirect | ||
| github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.3 // indirect | ||
| github.com/inconshreveable/mousetrap v1.1.0 // indirect | ||
| github.com/jmespath/go-jmespath v0.4.0 // indirect | ||
| github.com/josharian/intern v1.0.0 // indirect | ||
| github.com/json-iterator/go v1.1.12 // indirect | ||
| github.com/mailru/easyjson v0.7.7 // indirect | ||
| github.com/moby/term v0.5.0 // indirect | ||
| github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect | ||
| github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee // indirect | ||
| github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect | ||
| github.com/pkg/errors v0.9.1 // indirect | ||
| github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect | ||
| github.com/prometheus/client_model v0.6.1 // indirect | ||
| github.com/prometheus/common v0.62.0 // indirect | ||
| github.com/prometheus/procfs v0.15.1 // indirect | ||
| github.com/prometheus/client_model v0.6.2 // indirect | ||
| github.com/prometheus/common v0.66.1 // indirect | ||
| github.com/prometheus/procfs v0.16.1 // indirect | ||
| github.com/stoewer/go-strcase v1.3.0 // indirect | ||
| github.com/stretchr/objx v0.5.2 // indirect | ||
| github.com/x448/float16 v0.8.4 // indirect | ||
| go.etcd.io/etcd/api/v3 v3.6.4 // indirect | ||
| go.etcd.io/etcd/client/pkg/v3 v3.6.4 // indirect | ||
| go.etcd.io/etcd/client/v3 v3.6.4 // indirect | ||
| go.etcd.io/etcd/api/v3 v3.6.5 // indirect | ||
| go.etcd.io/etcd/client/pkg/v3 v3.6.5 // indirect | ||
| go.etcd.io/etcd/client/v3 v3.6.5 // indirect | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.60.0 // indirect | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.58.0 // indirect | ||
| go.opentelemetry.io/otel v1.35.0 // indirect | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.61.0 // indirect | ||
| go.opentelemetry.io/otel v1.40.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.34.0 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.34.0 // indirect | ||
| go.opentelemetry.io/otel/metric v1.35.0 // indirect | ||
| go.opentelemetry.io/otel/sdk v1.34.0 // indirect | ||
| go.opentelemetry.io/otel/trace v1.35.0 // indirect | ||
| go.opentelemetry.io/otel/metric v1.40.0 // indirect | ||
| go.opentelemetry.io/otel/sdk v1.40.0 // indirect | ||
| go.opentelemetry.io/otel/trace v1.40.0 // indirect | ||
| go.opentelemetry.io/proto/otlp v1.5.0 // indirect | ||
| go.uber.org/multierr v1.11.0 // indirect | ||
| go.uber.org/zap v1.27.0 // indirect | ||
| golang.org/x/crypto v0.36.0 // indirect | ||
| golang.org/x/crypto v0.45.0 // indirect | ||
| golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56 // indirect | ||
| golang.org/x/mod v0.23.0 // indirect | ||
| golang.org/x/net v0.38.0 // indirect | ||
| golang.org/x/oauth2 v0.27.0 // indirect | ||
| golang.org/x/sync v0.12.0 | ||
| golang.org/x/sys v0.31.0 // indirect | ||
| golang.org/x/term v0.30.0 // indirect | ||
| golang.org/x/text v0.23.0 // indirect | ||
| golang.org/x/tools v0.30.0 // indirect | ||
| golang.org/x/mod v0.29.0 // indirect | ||
| golang.org/x/net v0.47.0 // indirect | ||
| golang.org/x/oauth2 v0.30.0 // indirect | ||
| golang.org/x/sync v0.18.0 | ||
| golang.org/x/sys v0.40.0 // indirect | ||
| golang.org/x/term v0.37.0 // indirect | ||
| golang.org/x/text v0.31.0 // indirect | ||
| golang.org/x/tools v0.38.0 // indirect | ||
| google.golang.org/genproto/googleapis/api v0.0.0-20250303144028-a0af3efb3deb // indirect | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20250303144028-a0af3efb3deb // indirect | ||
| google.golang.org/grpc v1.72.1 // indirect | ||
| google.golang.org/protobuf v1.36.5 // indirect | ||
| k8s.io/apiserver v0.34.0 // indirect | ||
| k8s.io/component-helpers v0.34.0 // indirect | ||
| k8s.io/gengo/v2 v2.0.0-20250604051438-85fd79dbfd9f // indirect | ||
| k8s.io/kms v0.34.0 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20250710124328-f3f2b991d03b // indirect | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20250528174236-200df99c418a // indirect | ||
| google.golang.org/grpc v1.72.2 // indirect | ||
| google.golang.org/protobuf v1.36.8 // indirect | ||
| k8s.io/apiserver v0.35.0 // indirect | ||
| k8s.io/component-helpers v0.35.0 // indirect | ||
| k8s.io/gengo/v2 v2.0.0-20250922181213-ec3ebc5fd46b // indirect | ||
| k8s.io/kms v0.35.0 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912 // indirect | ||
| sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2 // indirect | ||
| sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 // indirect | ||
| sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 // indirect | ||
| sigs.k8s.io/yaml v1.6.0 // indirect | ||
| ) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run the final image as a non-root user.
The runtime stage has no
USER, so it defaults to root. That weakens container hardening.Proposed minimal fix
FROM registry.ci.openshift.org/ocp/4.22:base-rhel9 LABEL description="AWS Cloud Controller Manager" COPY --from=builder /build/aws-cloud-controller-manager /bin/aws-cloud-controller-manager +USER 65532 ENTRYPOINT [ "/bin/aws-cloud-controller-manager" ]As per coding guidelines, "Focus on major issues impacting performance, readability, maintainability and security."
📝 Committable suggestion
🤖 Prompt for AI Agents