Skip to content

SDN-5477: blocked-edges/4.14.40-OVNlibreswan: "is IPsec enabled?" PromQL #6225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Nov 12, 2024
Merged

SDN-5477: blocked-edges/4.14.40-OVNlibreswan: "is IPsec enabled?" PromQL #6225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions blocked-edges/4.14.40-OVNlibreswan.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ matchingRules:
- type: PromQL
promql:
promql: |
group by (resource) (max_over_time(apiserver_storage_objects{_id="",resource="egressips.k8s.ovn.org"}[1h]))
or on ()
group by (ipsec) (label_replace(max_over_time(ovnkube_controller_ipsec_enabled{_id=""}[1h]), "ipsec", "enabled (4.14)", "", "") == 1)
Copy link
Member

@pperiyasamy pperiyasamy Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ovnkube_controller_ipsec_enabled gauge metric is at zone/node level in 4.14, so this is set from every node. are we ok with this ?

Copy link
Member Author

@wking wking Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group by (ipsec) (...) will collapse matching ovnkube_controller_ipsec_enabled per ipsec label, and the label_replace ensures only a single enabled (4.14) value for that label. So that means that a single node reporting a value of 1 for that metric will get the cluster treated as IPsec-enabled as far as this risk is concerned. Which sounds like the semantics we want.

Copy link
Member

@pperiyasamy pperiyasamy Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @wking , that's great.

or on (_id)
0 * group by (ipsec) (label_replace(max_over_time(ovnkube_controller_ipsec_enabled{_id=""}[1h]), "ipsec", "disabled (4.14)", "", ""))
or on (_id)
group by (ipsec) (label_replace(max_over_time(ovnkube_master_ipsec_enabled{_id=""}[1h]), "ipsec", "enabled (4.13)", "", "") == 1)
or on (_id)
0 * group by (ipsec) (label_replace(max_over_time(ovnkube_master_ipsec_enabled{_id=""}[1h]), "ipsec", "disabled (4.13)", "", ""))
or on (_id)
-1 * group by (resource) (max_over_time(apiserver_storage_objects{_id="",resource="egressips.k8s.ovn.org"}[1h]))
or on (_id)
0 * group(max_over_time(apiserver_storage_objects{_id=""}[1h]))