From 12f9bfc9591620286779dcda5856825f314d4b3d Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Tue, 15 Aug 2023 20:24:30 -0700 Subject: [PATCH] blocked-edges/4.13.*-PersistentVolumeDiskIDSymlinks: Convert to Always To mitigate slow cache warming [1], like 99161903ac (Retire some older conditional edges which required PromQL eval, 2023-05-09, #3590). The fixedIn 4.13.4 entered stable-4.13 back in June: $ git --no-pager blame channels/stable-4.13.yaml | grep ' 4[.]13[.]4$' 90eca13b2 (Automated Stabilization Robot 2023-06-29 08:03:38 +0000 40) - 4.13.4 so it's unlikely that there are all that many folks still interested in updating to it, instead of a more recent 4.13.z. And anyone who is interested can still read the message and ticket, decide whether they're exposed, and update if they feel they aren't exposed (or if they feel they are exposed but can handle being bit). Generated with: $ for X in blocked-edges/*PersistentVolumeDiskIDSymlinks*; do CONTENT="$(grep -B100 matchingRules: "${X}"; printf -- '- type: %s\n' Always)"; echo "${CONTENT}" > "${X}"; done [1]: https://issues.redhat.com/browse/OTA-942 --- blocked-edges/4.13.0-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ .../4.13.0-ec.1-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ .../4.13.0-ec.2-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ .../4.13.0-ec.3-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ .../4.13.0-ec.4-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ .../4.13.0-rc.0-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ .../4.13.0-rc.2-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ .../4.13.0-rc.3-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ .../4.13.0-rc.4-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ .../4.13.0-rc.5-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ .../4.13.0-rc.6-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ .../4.13.0-rc.7-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ .../4.13.0-rc.8-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ blocked-edges/4.13.1-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ blocked-edges/4.13.2-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ blocked-edges/4.13.3-PersistentVolumeDiskIDSymlinks.yaml | 7 +------ 16 files changed, 16 insertions(+), 96 deletions(-) diff --git a/blocked-edges/4.13.0-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.0-PersistentVolumeDiskIDSymlinks.yaml index 532e0e2d5..f8a12890c 100644 --- a/blocked-edges/4.13.0-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.0-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.0-ec.1-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.0-ec.1-PersistentVolumeDiskIDSymlinks.yaml index 6e30bc8aa..cd64a12e3 100644 --- a/blocked-edges/4.13.0-ec.1-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.0-ec.1-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.0-ec.2-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.0-ec.2-PersistentVolumeDiskIDSymlinks.yaml index b428b9eef..b3b329517 100644 --- a/blocked-edges/4.13.0-ec.2-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.0-ec.2-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.0-ec.3-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.0-ec.3-PersistentVolumeDiskIDSymlinks.yaml index 499fc3d02..dc19ff013 100644 --- a/blocked-edges/4.13.0-ec.3-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.0-ec.3-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.0-ec.4-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.0-ec.4-PersistentVolumeDiskIDSymlinks.yaml index b45b37e40..8fbcad343 100644 --- a/blocked-edges/4.13.0-ec.4-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.0-ec.4-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.0-rc.0-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.0-rc.0-PersistentVolumeDiskIDSymlinks.yaml index 6eab83b4a..1ff129cdd 100644 --- a/blocked-edges/4.13.0-rc.0-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.0-rc.0-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.0-rc.2-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.0-rc.2-PersistentVolumeDiskIDSymlinks.yaml index a8ec22af0..9552a6548 100644 --- a/blocked-edges/4.13.0-rc.2-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.0-rc.2-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.0-rc.3-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.0-rc.3-PersistentVolumeDiskIDSymlinks.yaml index b637e62b9..688ca764f 100644 --- a/blocked-edges/4.13.0-rc.3-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.0-rc.3-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.0-rc.4-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.0-rc.4-PersistentVolumeDiskIDSymlinks.yaml index a270cafc6..dbc3a5488 100644 --- a/blocked-edges/4.13.0-rc.4-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.0-rc.4-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.0-rc.5-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.0-rc.5-PersistentVolumeDiskIDSymlinks.yaml index e935c2f38..ae6bf2466 100644 --- a/blocked-edges/4.13.0-rc.5-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.0-rc.5-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.0-rc.6-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.0-rc.6-PersistentVolumeDiskIDSymlinks.yaml index e790799b8..12ebaccb8 100644 --- a/blocked-edges/4.13.0-rc.6-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.0-rc.6-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.0-rc.7-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.0-rc.7-PersistentVolumeDiskIDSymlinks.yaml index 575d10a65..bfc1a03cb 100644 --- a/blocked-edges/4.13.0-rc.7-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.0-rc.7-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.0-rc.8-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.0-rc.8-PersistentVolumeDiskIDSymlinks.yaml index 8ee1a0832..f91abb78f 100644 --- a/blocked-edges/4.13.0-rc.8-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.0-rc.8-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.1-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.1-PersistentVolumeDiskIDSymlinks.yaml index a02eb99fe..594c0317b 100644 --- a/blocked-edges/4.13.1-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.1-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.2-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.2-PersistentVolumeDiskIDSymlinks.yaml index 76b615aaf..2cdc9175e 100644 --- a/blocked-edges/4.13.2-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.2-PersistentVolumeDiskIDSymlinks.yaml @@ -5,9 +5,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always diff --git a/blocked-edges/4.13.3-PersistentVolumeDiskIDSymlinks.yaml b/blocked-edges/4.13.3-PersistentVolumeDiskIDSymlinks.yaml index a0486b0d7..abd57ff00 100644 --- a/blocked-edges/4.13.3-PersistentVolumeDiskIDSymlinks.yaml +++ b/blocked-edges/4.13.3-PersistentVolumeDiskIDSymlinks.yaml @@ -6,9 +6,4 @@ name: PersistentVolumeDiskIDSymlinks message: |- New PersistentVolumes are created bound to an invalid symlink instead of the correct one and thus fail once updated to 4.13.4 or later as the invalid symlink dispears. matchingRules: -- type: PromQL - promql: - promql: | - group(csv_succeeded{name=~"local-storage-operator[.].*"}) - or - 0 * group(csv_count) +- type: Always