From 2c0dd242e81f47f1874263ba9dfbb3fa2b93b1a1 Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Thu, 8 Oct 2020 09:38:58 -0700 Subject: [PATCH] pkg/steps/template: Push "Executing pod..." logging into createOrRestartPod This seems generically useful, and not something that needs to be restricted to multi-step, where it has been since 8cf5f87d55 (ci-operator multi-stage: MultiStageTestStep, 2019-07-30, #100). --- pkg/steps/multi_stage.go | 1 - pkg/steps/template.go | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/steps/multi_stage.go b/pkg/steps/multi_stage.go index b76df8b03dd..1b5dd69143b 100644 --- a/pkg/steps/multi_stage.go +++ b/pkg/steps/multi_stage.go @@ -522,7 +522,6 @@ func (s *multiStageTestStep) runPods(ctx context.Context, pods []coreapi.Pod, sh namePrefix := s.name + "-" var errs []error for _, pod := range pods { - log.Printf("Executing %q", pod.Name) var notifier ContainerNotifier = NopNotifier for _, c := range pod.Spec.Containers { if c.Name == "artifacts" { diff --git a/pkg/steps/template.go b/pkg/steps/template.go index 692894e8e3e..a3c3830e202 100644 --- a/pkg/steps/template.go +++ b/pkg/steps/template.go @@ -407,6 +407,7 @@ func createOrRestartPod(podClient coreclientset.PodInterface, pod *coreapi.Pod) return nil, fmt.Errorf("unable to delete completed pod: %w", err) } var created *coreapi.Pod + log.Printf("Executing pod %q", pod.Name) // creating a pod in close proximity to namespace creation can result in forbidden errors due to // initializing secrets or policy - use a short backoff to mitigate flakes if err := wait.ExponentialBackoff(wait.Backoff{Steps: 4, Factor: 2, Duration: time.Second}, func() (bool, error) {