From 3f660d24d5784368fdce2a134c4629655b759cbd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bruno=20Barcarol=20Guimar=C3=A3es?= Date: Thu, 28 Mar 2019 13:43:15 +0000 Subject: [PATCH] rehearse: don't update existing configmaps A hash of the content is included in the name, updates are (practically) unnecessary. --- pkg/config/template.go | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/pkg/config/template.go b/pkg/config/template.go index 99ff9dba..a7024572 100644 --- a/pkg/config/template.go +++ b/pkg/config/template.go @@ -108,14 +108,8 @@ func (c *TemplateCMManager) CreateCMTemplates() error { } c.logger.WithFields(logrus.Fields{"template-name": templateName, "cm-name": cmName}).Info("creating rehearsal configMap for template") - if _, err := c.cmclient.Create(cm); err != nil { - if kerrors.IsAlreadyExists(err) { - if _, err := c.cmclient.Update(cm); err != nil { - errors = append(errors, fmt.Errorf("could not update existing configmap: %v", err)) - } - } else { - errors = append(errors, err) - } + if _, err := c.cmclient.Create(cm); err != nil && !kerrors.IsAlreadyExists(err) { + errors = append(errors, err) } } return kutilerrors.NewAggregate(errors)