Single-quote output:dir controller-gen option. #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first argument of the shell invocation `controller-gen output:dir="foo"` reaches controller-gen as output:dir=foo. Without the quotes, certain values for output:dir confuse controller-gen's option parsing as it attempts to guess the value's type. For example: $ controller-gen output:dir="/tmp/tmp.1Pbg8eLCZK" # interpreted as an invalid floating-point number Error: unable to parse option "output:dir=/tmp/tmp.1Pbg8eLCZK": ['P' exponent requires hexadecimal mantissa (at <input>:1:9) exponent has no digits (at <input>:1:9)]
benluddy
force-pushed
the
singlequote-controllergen-outputdir
branch
from
46c53ee to
9ada339
Compare
Contributor
|
@benluddy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first argument of the shell invocation
controller-gen output:dir="foo"reaches controller-gen as output:dir=foo. Withoutthe quotes, certain values for output:dir confuse controller-gen's option parsing as it attempts to guess the value's type.
For example: