Skip to content

MCO-1759: Add NonReconcilableMC Feature Gate #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Aug 5, 2025
Merged

MCO-1759: Add NonReconcilableMC Feature Gate #2429

openshift-merge-bot merged 1 commit into from
Aug 5, 2025

Conversation

@pablintino
Copy link
Contributor

@pablintino pablintino commented Jul 30, 2025 •
edited
Loading

Add the feature gate for the https://issues.redhat.com/browse/MCO-1002 work.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 30, 2025 •
edited by openshift-ci bot
Loading

@pablintino: This pull request references MCO-1759 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2025

Hello @pablintino! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 30, 2025 •
edited by openshift-ci bot
Loading

@pablintino: This pull request references MCO-1759 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Add the feature gate for the https://issues.redhat.com/browse/MCO-1002 work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from JoelSpeed and deads2k July 30, 2025 11:28
JoelSpeed
JoelSpeed reviewed Jul 30, 2025
View reviewed changes
features/features.go Outdated
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
mustRegister()

FeatureGateNonReconcilableMC = newFeatureGate("NonReconcilableMC").
Copy link
Contributor

@JoelSpeed JoelSpeed Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, any reason not to spell out MachineConfig?

Copy link
Contributor Author

@pablintino pablintino Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing in particular. Given that all Feature Gates seem to use long names I've changed the name.

@pablintino pablintino force-pushed the mco-1759-nonreconcilable-changes-feature-gate branch from b69840a to 9a589ff Compare July 30, 2025 12:21
@pablintino
Copy link
Contributor Author

pablintino commented Jul 30, 2025

/retest-required

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Jul 31, 2025

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2025

/retest-required

Remaining retests: 0 against base HEAD ed654ed and 2 for PR HEAD 9a589ff in total

@pablintino
Copy link
Contributor Author

pablintino commented Jul 31, 2025

/hold
The final name we gave to the feature in our docs is MachineConfig Irreconcilable Changes. I'd prefer to use the same naming here too.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2025
@pablintino pablintino force-pushed the mco-1759-nonreconcilable-changes-feature-gate branch from 9a589ff to 2a511b4 Compare July 31, 2025 11:53
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Jul 31, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pablintino
Copy link
Contributor Author

pablintino commented Jul 31, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2025

/retest-required

Remaining retests: 0 against base HEAD ed654ed and 2 for PR HEAD 2a511b4 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2025

/retest-required

Remaining retests: 0 against base HEAD c7fbd08 and 1 for PR HEAD 2a511b4 in total

@pablintino
Copy link
Contributor Author

pablintino commented Aug 1, 2025

/retest-required

2 similar comments
@pablintino
Copy link
Contributor Author

pablintino commented Aug 1, 2025

/retest-required

@pablintino
Copy link
Contributor Author

pablintino commented Aug 1, 2025

/retest-required

@pablintino
Copy link
Contributor Author

pablintino commented Aug 2, 2025

/retest-required

@pablintino
Copy link
Contributor Author

pablintino commented Aug 2, 2025

/test e2e-aws-ovn-techpreview

@pablintino
Copy link
Contributor Author

pablintino commented Aug 4, 2025

/retest-required

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Aug 4, 2025

/override ci/prow/e2e-aws-ovn-techpreview

Based on https://issues.redhat.com/browse/OCPBUGS-59603, the test failure is a known flake

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn-techpreview

In response to this:

/override ci/prow/e2e-aws-ovn-techpreview

Based on https://issues.redhat.com/browse/OCPBUGS-59603, the test failure is a known flake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pablintino
Copy link
Contributor Author

pablintino commented Aug 4, 2025

/test e2e-upgrade
/test e2e-aws-serial-2of2

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 4, 2025

/retest-required

Remaining retests: 0 against base HEAD 32616f0 and 2 for PR HEAD 2a511b4 in total

@pablintino
Copy link
Contributor Author

pablintino commented Aug 4, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2025 •
edited
Loading

@pablintino: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 2a511b4 link false /test e2e-gcp
ci/prow/e2e-azure 2a511b4 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 5, 2025

/retest-required

Remaining retests: 0 against base HEAD 32616f0 and 2 for PR HEAD 2a511b4 in total

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 5, 2025

/retest-required

Remaining retests: 0 against base HEAD 32616f0 and 2 for PR HEAD 2a511b4 in total

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Aug 5, 2025

/override ci/prow/e2e-aws-ovn-techpreview

Based on https://issues.redhat.com/browse/OCPBUGS-59603, the test failure is a known flake

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn-techpreview

In response to this:

/override ci/prow/e2e-aws-ovn-techpreview

Based on https://issues.redhat.com/browse/OCPBUGS-59603, the test failure is a known flake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9f36190 into openshift:master Aug 5, 2025
25 of 27 checks passed
@openshift-bot
Copy link

openshift-bot commented Aug 5, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202508051116.p0.g9f36190.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablintino @openshift-ci-robot @JoelSpeed @openshift-bot