Add omitempty to dnsmanagementpolicy

[thejasn]

Signed-off-by: Thejas N [email protected]

[openshift-ci]

Hello @thejasn! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label <labelname> command.

Who should apply these qe/docs/px labels?

• For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
• For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
• For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

[JoelSpeed]

/lgtm
/assign @deads2k for approval

This was discussed on slack, the lack of omitempty causes the default to be set by openapi which then won't pass validation. With omitempty, validation passes and then the default is set

[openshift-ci]

@JoelSpeed: GitHub didn't allow me to assign the following users: approval, for.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/lgtm
/assign @deads2k for approval

This was discussed on slack, the lack of omitempty causes the default to be set by openapi which then won't pass validation. With omitempty, validation passes and then the default is set

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[deads2k]

So the problem is that this value here should be Managed?

[JoelSpeed]

Yes, we need the defaults to be accepted in both OpenAPI and controller-tools, except they use different tags, so right now the default is "" which is causing validation issues. You must have omitempty to have a non-empty default here as well

[JoelSpeed]

@thejasn Please apply the two suggestions and regenerate and I think this is good

[thejasn]

/retest

[JoelSpeed]

I've been experimenting with this and as far as I can tell this makes things works as they stand today with client-side and server-side validation

We want to have the correct default in the openapi.json, and to achieve this, we need to add omitempty and the default tag.

There's an open question about optional vs required for defaulting but I think that can be handled separately as this resolves the validations for server side (which means anything using client-go should work) and client-side validation is also happy right now.

/lgtm

[thejasn]

/hold
cc: @Miciah

[JoelSpeed]

/lgtm

[deads2k]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed, thejasn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[thejasn]

/unhold

[Amrita42]

/label docs-approved

[quarterpin]

/label qe-approved

[CFields651]

/label px-approved

[openshift-ci]

@thejasn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.