Remove upstream on-by-default feature gates (CloudDualStackNodeIPs, DisableKubeletCloudCredentialProviders, ValidatingAdmissionPolicy)

JoelSpeed · JoelSpeed · commit 54ba57c9e620 · 2025-03-26T14:07:12.000Z
diff --git a/features.md b/features.md
@@ -75,8 +75,6 @@
 | BareMetalLoadBalancer| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | BuildCSIVolumes| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | ChunkSizeMiB| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
-| CloudDualStackNodeIPs| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
-| DisableKubeletCloudCredentialProviders| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | GCPLabelsTags| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | HardwareSpeed| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | IngressControllerLBSubnetsAWS| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
@@ -97,4 +95,3 @@
 | VSphereDriverConfiguration| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | VSphereMultiVCenters| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | VSphereStaticIPs| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
-| ValidatingAdmissionPolicy| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
diff --git a/features/features.go b/features/features.go
@@ -52,14 +52,6 @@ var (
 							enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
 							mustRegister()
 
-	FeatureGateValidatingAdmissionPolicy = newFeatureGate("ValidatingAdmissionPolicy").
-						reportProblemsToJiraComponent("kube-apiserver").
-						contactPerson("benluddy").
-						productScope(kubernetes).
-						enhancementPR("https://github.com/kubernetes/enhancements/issues/3488").
-						enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
-						mustRegister()
-
 	FeatureGateGatewayAPI = newFeatureGate("GatewayAPI").
 				reportProblemsToJiraComponent("Routing").
 				contactPerson("miciah").
@@ -195,14 +187,6 @@ var (
 					enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
 					mustRegister()
 
-	FeatureGateCloudDualStackNodeIPs = newFeatureGate("CloudDualStackNodeIPs").
-						reportProblemsToJiraComponent("machine-config-operator/platform-baremetal").
-						contactPerson("mkowalsk").
-						productScope(kubernetes).
-						enhancementPR("https://github.com/kubernetes/enhancements/issues/3705").
-						enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
-						mustRegister()
-
 	FeatureGateVSphereHostVMGroupZonal = newFeatureGate("VSphereHostVMGroupZonal").
 						reportProblemsToJiraComponent("splat").
 						contactPerson("jcpowermac").
@@ -409,14 +393,6 @@ var (
 					enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
 					mustRegister()
 
-	FeatureGateDisableKubeletCloudCredentialProviders = newFeatureGate("DisableKubeletCloudCredentialProviders").
-								reportProblemsToJiraComponent("cloud-provider").
-								contactPerson("jspeed").
-								productScope(kubernetes).
-								enhancementPR("https://github.com/kubernetes/enhancements/issues/2395").
-								enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
-								mustRegister()
-
 	FeatureGateOnClusterBuild = newFeatureGate("OnClusterBuild").
 					reportProblemsToJiraComponent("MachineConfigOperator").
 					contactPerson("dkhater").
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml b/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
@@ -237,12 +237,6 @@
                     {
                         "name": "ChunkSizeMiB"
                     },
-                    {
-                        "name": "CloudDualStackNodeIPs"
-                    },
-                    {
-                        "name": "DisableKubeletCloudCredentialProviders"
-                    },
                     {
                         "name": "ExternalOIDC"
                     },
@@ -305,9 +299,6 @@
                     },
                     {
                         "name": "VSphereStaticIPs"
-                    },
-                    {
-                        "name": "ValidatingAdmissionPolicy"
                     }
                 ],
                 "version": ""
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml
@@ -77,9 +77,6 @@
                     {
                         "name": "ChunkSizeMiB"
                     },
-                    {
-                        "name": "CloudDualStackNodeIPs"
-                    },
                     {
                         "name": "ClusterMonitoringConfig"
                     },
@@ -92,9 +89,6 @@
                     {
                         "name": "DNSNameResolver"
                     },
-                    {
-                        "name": "DisableKubeletCloudCredentialProviders"
-                    },
                     {
                         "name": "DualReplica"
                     },
@@ -302,9 +296,6 @@
                     {
                         "name": "VSphereStaticIPs"
                     },
-                    {
-                        "name": "ValidatingAdmissionPolicy"
-                    },
                     {
                         "name": "VolumeAttributesClass"
                     },
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
@@ -95,9 +95,6 @@
                     {
                         "name": "ChunkSizeMiB"
                     },
-                    {
-                        "name": "CloudDualStackNodeIPs"
-                    },
                     {
                         "name": "ClusterMonitoringConfig"
                     },
@@ -107,9 +104,6 @@
                     {
                         "name": "DNSNameResolver"
                     },
-                    {
-                        "name": "DisableKubeletCloudCredentialProviders"
-                    },
                     {
                         "name": "DualReplica"
                     },
@@ -302,9 +296,6 @@
                     {
                         "name": "VSphereStaticIPs"
                     },
-                    {
-                        "name": "ValidatingAdmissionPolicy"
-                    },
                     {
                         "name": "VolumeAttributesClass"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
@@ -237,12 +237,6 @@
                     {
                         "name": "ChunkSizeMiB"
                     },
-                    {
-                        "name": "CloudDualStackNodeIPs"
-                    },
-                    {
-                        "name": "DisableKubeletCloudCredentialProviders"
-                    },
                     {
                         "name": "GCPLabelsTags"
                     },
@@ -305,9 +299,6 @@
                     },
                     {
                         "name": "VSphereStaticIPs"
-                    },
-                    {
-                        "name": "ValidatingAdmissionPolicy"
                     }
                 ],
                 "version": ""
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml
@@ -71,9 +71,6 @@
                     {
                         "name": "ChunkSizeMiB"
                     },
-                    {
-                        "name": "CloudDualStackNodeIPs"
-                    },
                     {
                         "name": "ClusterMonitoringConfig"
                     },
@@ -86,9 +83,6 @@
                     {
                         "name": "DNSNameResolver"
                     },
-                    {
-                        "name": "DisableKubeletCloudCredentialProviders"
-                    },
                     {
                         "name": "DualReplica"
                     },
@@ -302,9 +296,6 @@
                     {
                         "name": "VSphereStaticIPs"
                     },
-                    {
-                        "name": "ValidatingAdmissionPolicy"
-                    },
                     {
                         "name": "VolumeAttributesClass"
                     },
diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
@@ -89,9 +89,6 @@
                     {
                         "name": "ChunkSizeMiB"
                     },
-                    {
-                        "name": "CloudDualStackNodeIPs"
-                    },
                     {
                         "name": "ClusterMonitoringConfig"
                     },
@@ -101,9 +98,6 @@
                     {
                         "name": "DNSNameResolver"
                     },
-                    {
-                        "name": "DisableKubeletCloudCredentialProviders"
-                    },
                     {
                         "name": "DualReplica"
                     },
@@ -302,9 +296,6 @@
                     {
                         "name": "VSphereStaticIPs"
                     },
-                    {
-                        "name": "ValidatingAdmissionPolicy"
-                    },
                     {
                         "name": "VolumeAttributesClass"
                     },

Original file line number	Diff line number	Diff line change
`@@ -237,12 +237,6 @@`
`237`	`237`	`{`
`238`	`238`	`"name": "ChunkSizeMiB"`
`239`	`239`	`},`
`240`		`- {`
`241`		`- "name": "CloudDualStackNodeIPs"`
`242`		`- },`
`243`		`- {`
`244`		`- "name": "DisableKubeletCloudCredentialProviders"`
`245`		`- },`
`246`	`240`	`{`
`247`	`241`	`"name": "ExternalOIDC"`
`248`	`242`	`},`
`@@ -305,9 +299,6 @@`
`305`	`299`	`},`
`306`	`300`	`{`
`307`	`301`	`"name": "VSphereStaticIPs"`
`308`		`- },`
`309`		`- {`
`310`		`- "name": "ValidatingAdmissionPolicy"`
`311`	`302`	`}`
`312`	`303`	`],`
`313`	`304`	`"version": ""`
Original file line number	Diff line number	Diff line change
`@@ -77,9 +77,6 @@`
`77`	`77`	`{`
`78`	`78`	`"name": "ChunkSizeMiB"`
`79`	`79`	`},`
`80`		`- {`
`81`		`- "name": "CloudDualStackNodeIPs"`
`82`		`- },`
`83`	`80`	`{`
`84`	`81`	`"name": "ClusterMonitoringConfig"`
`85`	`82`	`},`
`@@ -92,9 +89,6 @@`
`92`	`89`	`{`
`93`	`90`	`"name": "DNSNameResolver"`
`94`	`91`	`},`
`95`		`- {`
`96`		`- "name": "DisableKubeletCloudCredentialProviders"`
`97`		`- },`
`98`	`92`	`{`
`99`	`93`	`"name": "DualReplica"`
`100`	`94`	`},`
`@@ -302,9 +296,6 @@`
`302`	`296`	`{`
`303`	`297`	`"name": "VSphereStaticIPs"`
`304`	`298`	`},`
`305`		`- {`
`306`		`- "name": "ValidatingAdmissionPolicy"`
`307`		`- },`
`308`	`299`	`{`
`309`	`300`	`"name": "VolumeAttributesClass"`
`310`	`301`	`},`
Original file line number	Diff line number	Diff line change
`@@ -95,9 +95,6 @@`
`95`	`95`	`{`
`96`	`96`	`"name": "ChunkSizeMiB"`
`97`	`97`	`},`
`98`		`- {`
`99`		`- "name": "CloudDualStackNodeIPs"`
`100`		`- },`
`101`	`98`	`{`
`102`	`99`	`"name": "ClusterMonitoringConfig"`
`103`	`100`	`},`
`@@ -107,9 +104,6 @@`
`107`	`104`	`{`
`108`	`105`	`"name": "DNSNameResolver"`
`109`	`106`	`},`
`110`		`- {`
`111`		`- "name": "DisableKubeletCloudCredentialProviders"`
`112`		`- },`
`113`	`107`	`{`
`114`	`108`	`"name": "DualReplica"`
`115`	`109`	`},`
`@@ -302,9 +296,6 @@`
`302`	`296`	`{`
`303`	`297`	`"name": "VSphereStaticIPs"`
`304`	`298`	`},`
`305`		`- {`
`306`		`- "name": "ValidatingAdmissionPolicy"`
`307`		`- },`
`308`	`299`	`{`
`309`	`300`	`"name": "VolumeAttributesClass"`
`310`	`301`	`},`
Original file line number	Diff line number	Diff line change
`@@ -71,9 +71,6 @@`
`71`	`71`	`{`
`72`	`72`	`"name": "ChunkSizeMiB"`
`73`	`73`	`},`
`74`		`- {`
`75`		`- "name": "CloudDualStackNodeIPs"`
`76`		`- },`
`77`	`74`	`{`
`78`	`75`	`"name": "ClusterMonitoringConfig"`
`79`	`76`	`},`
`@@ -86,9 +83,6 @@`
`86`	`83`	`{`
`87`	`84`	`"name": "DNSNameResolver"`
`88`	`85`	`},`
`89`		`- {`
`90`		`- "name": "DisableKubeletCloudCredentialProviders"`
`91`		`- },`
`92`	`86`	`{`
`93`	`87`	`"name": "DualReplica"`
`94`	`88`	`},`
`@@ -302,9 +296,6 @@`
`302`	`296`	`{`
`303`	`297`	`"name": "VSphereStaticIPs"`
`304`	`298`	`},`
`305`		`- {`
`306`		`- "name": "ValidatingAdmissionPolicy"`
`307`		`- },`
`308`	`299`	`{`
`309`	`300`	`"name": "VolumeAttributesClass"`
`310`	`301`	`},`
Original file line number	Diff line number	Diff line change
`@@ -89,9 +89,6 @@`
`89`	`89`	`{`
`90`	`90`	`"name": "ChunkSizeMiB"`
`91`	`91`	`},`
`92`		`- {`
`93`		`- "name": "CloudDualStackNodeIPs"`
`94`		`- },`
`95`	`92`	`{`
`96`	`93`	`"name": "ClusterMonitoringConfig"`
`97`	`94`	`},`
`@@ -101,9 +98,6 @@`
`101`	`98`	`{`
`102`	`99`	`"name": "DNSNameResolver"`
`103`	`100`	`},`
`104`		`- {`
`105`		`- "name": "DisableKubeletCloudCredentialProviders"`
`106`		`- },`
`107`	`101`	`{`
`108`	`102`	`"name": "DualReplica"`
`109`	`103`	`},`
`@@ -302,9 +296,6 @@`
`302`	`296`	`{`
`303`	`297`	`"name": "VSphereStaticIPs"`
`304`	`298`	`},`
`305`		`- {`
`306`		`- "name": "ValidatingAdmissionPolicy"`
`307`		`- },`
`308`	`299`	`{`
`309`	`300`	`"name": "VolumeAttributesClass"`
`310`	`301`	`},`