Add omitempty to dnsmanagementpolicy

Make dnsManagementPolicy required

Signed-off-by: Thejas N <[email protected]>

Author: Thejas N

openapi/generated_openapi/zz_generated.openapi.go

@@ -23723,7 +23723,7 @@
         "dnsManagementPolicy": {
           "description": "dnsManagementPolicy indicates if the lifecycle of the wildcard DNS record associated with the load balancer service will be managed by the ingress operator. It defaults to Managed. Valid values are: Managed and Unmanaged.",
           "type": "string",
-          "default": ""
+          "default": "Managed"
         },
         "providerParameters": {
           "description": "providerParameters holds desired load balancer information specific to the underlying infrastructure provider.\n\nIf empty, defaults will be applied. See specific providerParameters fields for details about their defaults.",
@@ -26408,7 +26408,7 @@
         "dnsManagementPolicy": {
           "description": "dnsManagementPolicy denotes the current policy applied on the DNS record. Records that have policy set as \"Unmanaged\" are ignored by the ingress operator.  This means that the DNS record on the cloud provider is not managed by the operator, and the \"Published\" status condition will be updated to \"Unknown\" status, since it is externally managed. Any existing record on the cloud provider can be deleted at the discretion of the cluster admin.\n\nThis field defaults to Managed. Valid values are \"Managed\" and \"Unmanaged\".",
           "type": "string",
-          "default": ""
+          "default": "Managed"
         },
         "dnsName": {
           "description": "dnsName is the hostname of the DNS record",

openapi/openapi.json

@@ -327,6 +327,7 @@ spec:
                         - External
                         type: string
                     required:
+                    - dnsManagementPolicy
                     - scope
                     type: object
                   nodePort:
@@ -442,20 +443,20 @@ spec:
                         \"text/*\", \"image/svg+xml\", \"application/octet-stream\",
                         \"X-custom/customsub\", etc. \n The format should follow the
                         Content-Type definition in RFC 1341: Content-Type := type
-                        \"/\" subtype *[\";\" parameter] - The type in Content-Type
-                        can be one of:   application, audio, image, message, multipart,
-                        text, video, or a custom   type preceded by \"X-\" and followed
-                        by a token as defined below. - The token is a string of at
-                        least one character, and not containing white   space, control
-                        characters, or any of the characters in the tspecials set.
-                        - The tspecials set contains the characters ()<>@,;:\\\"/[]?.=
-                        - The subtype in Content-Type is also a token. - The optional
-                        parameter/s following the subtype are defined as:   token
-                        \"=\" (token / quoted-string) - The quoted-string, as defined
-                        in RFC 822, is surrounded by double quotes   and can contain
-                        white space plus any character EXCEPT \\, \", and CR.   It
-                        can also contain any single ASCII character as long as it
-                        is escaped by \\."
+                        \"/\" subtype *[\";\" parameter]   - The type in Content-Type
+                        can be one of:     application, audio, image, message, multipart,
+                        text, video, or a custom     type preceded by \"X-\" and followed
+                        by a token as defined below.   - The token is a string of
+                        at least one character, and not containing white     space,
+                        control characters, or any of the characters in the tspecials
+                        set.   - The tspecials set contains the characters ()<>@,;:\\\"/[]?.=
+                        \  - The subtype in Content-Type is also a token.   - The
+                        optional parameter/s following the subtype are defined as:
+                        \    token \"=\" (token / quoted-string)   - The quoted-string,
+                        as defined in RFC 822, is surrounded by double quotes     and
+                        can contain white space plus any character EXCEPT \\, \",
+                        and CR.     It can also contain any single ASCII character
+                        as long as it is escaped by \\."
                       pattern: ^(?i)(x-[^][ ()\\<>@,;:"/?.=\x00-\x1F\x7F]+|application|audio|image|message|multipart|text|video)/[^][
                         ()\\<>@,;:"/?.=\x00-\x1F\x7F]+(; *[^][ ()\\<>@,;:"/?.=\x00-\x1F\x7F]+=([^][
                         ()\\<>@,;:"/?.=\x00-\x1F\x7F]+|"(\\[\x00-\x7F]|[^\x0D"\\])*"))*$
@@ -1612,6 +1613,7 @@ spec:
                         - External
                         type: string
                     required:
+                    - dnsManagementPolicy
                     - scope
                     type: object
                   nodePort:

operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml

@@ -280,18 +280,18 @@ type HTTPCompressionPolicy struct {
 //
 // The format should follow the Content-Type definition in RFC 1341:
 // Content-Type := type "/" subtype *[";" parameter]
-// - The type in Content-Type can be one of:
-//   application, audio, image, message, multipart, text, video, or a custom
-//   type preceded by "X-" and followed by a token as defined below.
-// - The token is a string of at least one character, and not containing white
-//   space, control characters, or any of the characters in the tspecials set.
-// - The tspecials set contains the characters ()<>@,;:\"/[]?.=
-// - The subtype in Content-Type is also a token.
-// - The optional parameter/s following the subtype are defined as:
-//   token "=" (token / quoted-string)
-// - The quoted-string, as defined in RFC 822, is surrounded by double quotes
-//   and can contain white space plus any character EXCEPT \, ", and CR.
-//   It can also contain any single ASCII character as long as it is escaped by \.
+//   - The type in Content-Type can be one of:
+//     application, audio, image, message, multipart, text, video, or a custom
+//     type preceded by "X-" and followed by a token as defined below.
+//   - The token is a string of at least one character, and not containing white
+//     space, control characters, or any of the characters in the tspecials set.
+//   - The tspecials set contains the characters ()<>@,;:\"/[]?.=
+//   - The subtype in Content-Type is also a token.
+//   - The optional parameter/s following the subtype are defined as:
+//     token "=" (token / quoted-string)
+//   - The quoted-string, as defined in RFC 822, is surrounded by double quotes
+//     and can contain white space plus any character EXCEPT \, ", and CR.
+//     It can also contain any single ASCII character as long as it is escaped by \.
 //
 // +kubebuilder:validation:Pattern=`^(?i)(x-[^][ ()\\<>@,;:"/?.=\x00-\x1F\x7F]+|application|audio|image|message|multipart|text|video)/[^][ ()\\<>@,;:"/?.=\x00-\x1F\x7F]+(; *[^][ ()\\<>@,;:"/?.=\x00-\x1F\x7F]+=([^][ ()\\<>@,;:"/?.=\x00-\x1F\x7F]+|"(\\[\x00-\x7F]|[^\x0D"\\])*"))*$`
 type CompressionMIMEType string
@@ -391,9 +391,10 @@ type LoadBalancerStrategy struct {
 	// Valid values are: Managed and Unmanaged.
 	//
 	// +kubebuilder:default:="Managed"
-	// +kubebuilder:validation:Optional
-	// +optional
-	DNSManagementPolicy LoadBalancerDNSManagementPolicy `json:"dnsManagementPolicy"`
+	// +kubebuilder:validation:Required
+	// +required
+	// +default="Managed"
+	DNSManagementPolicy LoadBalancerDNSManagementPolicy `json:"dnsManagementPolicy,omitempty"`
 }
 
 // LoadBalancerDNSManagementPolicy is a policy for configuring how
@@ -559,8 +560,7 @@ type AWSClassicLoadBalancerParameters struct {
 
 // AWSNetworkLoadBalancerParameters holds configuration parameters for an
 // AWS Network load balancer.
-type AWSNetworkLoadBalancerParameters struct {
-}
+type AWSNetworkLoadBalancerParameters struct{}
 
 // HostNetworkStrategy holds parameters for the HostNetwork endpoint publishing
 // strategy.
@@ -965,8 +965,7 @@ type SyslogLoggingDestinationParameters struct {
 
 // ContainerLoggingDestinationParameters describes parameters for the Container
 // logging destination type.
-type ContainerLoggingDestinationParameters struct {
-}
+type ContainerLoggingDestinationParameters struct{}
 
 // LoggingDestination describes a destination for log messages.
 // +union

operator/v1/types_ingress.go

@@ -38,6 +38,7 @@ spec:
               description: spec is the specification of the desired behavior of the dnsRecord.
               type: object
               required:
+                - dnsManagementPolicy
                 - dnsName
                 - recordTTL
                 - recordType

operatoringress/v1/0000_50_dns-record.yaml

@@ -70,9 +70,10 @@ type DNSRecordSpec struct {
 	// "Unmanaged".
 	//
 	// +kubebuilder:default:="Managed"
-	// +kubebuilder:validation:Optional
-	// +optional
-	DNSManagementPolicy DNSManagementPolicy `json:"dnsManagementPolicy"`
+	// +kubebuilder:validation:Required
+	// +required
+	// +default="Managed"
+	DNSManagementPolicy DNSManagementPolicy `json:"dnsManagementPolicy,omitempty"`
 }
 
 // DNSRecordStatus is the most recently observed status of each record.