Apply suggestions from code review

thejasn · JoelSpeed · web-flow · commit 1d05d34fd49e · 2022-08-26T20:15:09.000+05:30
Co-authored-by: Joel Speed &lt;Joel.speed@hotmail.co.uk&gt;
diff --git a/operator/v1/types_ingress.go b/operator/v1/types_ingress.go
@@ -393,6 +393,7 @@ type LoadBalancerStrategy struct {
 	// +kubebuilder:default:="Managed"
 	// +kubebuilder:validation:Optional
 	// +optional
+	// +default="Managed"
 	DNSManagementPolicy LoadBalancerDNSManagementPolicy `json:"dnsManagementPolicy,omitempty"`
 }
 
diff --git a/operatoringress/v1/types.go b/operatoringress/v1/types.go
@@ -72,7 +72,8 @@ type DNSRecordSpec struct {
 	// +kubebuilder:default:="Managed"
 	// +kubebuilder:validation:Optional
 	// +optional
-	DNSManagementPolicy DNSManagementPolicy `json:"dnsManagementPolicy,omitempty"`
+	// +default="Managed"
+	DNSManagementPolicy LoadBalancerDNSManagementPolicy `json:"dnsManagementPolicy,omitempty"`
 }
 
 // DNSRecordStatus is the most recently observed status of each record.

Original file line number	Diff line number	Diff line change
`@@ -393,6 +393,7 @@ type LoadBalancerStrategy struct {`
`393`	`393`	`// +kubebuilder:default:="Managed"`
`394`	`394`	`// +kubebuilder:validation:Optional`
`395`	`395`	`// +optional`
	`396`	`+ // +default="Managed"`
`396`	`397`	DNSManagementPolicy LoadBalancerDNSManagementPolicy `json:"dnsManagementPolicy,omitempty"`
`397`	`398`	`}`
`398`	`399`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,8 @@ type DNSRecordSpec struct {`
`72`	`72`	`// +kubebuilder:default:="Managed"`
`73`	`73`	`// +kubebuilder:validation:Optional`
`74`	`74`	`// +optional`
`75`		- DNSManagementPolicy DNSManagementPolicy `json:"dnsManagementPolicy,omitempty"`
	`75`	`+ // +default="Managed"`
	`76`	+ DNSManagementPolicy LoadBalancerDNSManagementPolicy `json:"dnsManagementPolicy,omitempty"`
`76`	`77`	`}`
`77`	`78`
`78`	`79`	`// DNSRecordStatus is the most recently observed status of each record.`