Addressing comments on 2.9 release notes #1863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Ksyunz <[email protected]>
MaxKsyunz
requested review from
GumpacG,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1863 +/- ##
============================================
+ Coverage 97.39% 99.98% +2.59%
+ Complexity 4602 2624 -1978
============================================
Files 401 205 -196
Lines 11386 5955 -5431
Branches 843 378 -465
============================================
- Hits 11089 5954 -5135
+ Misses 290 1 -289
+ Partials 7 0 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Collaborator
Yury-Fridlyand
left a comment
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
LGFM, but I want to ensure that log4j doesn't come to 2.9.
Waiting for opensearch-project/OpenSearch#8667 (comment) and #1861
|
|
||
| * Updated documentation of round function return type ([#1725](https://github.com/opensearch-project/sql/pull/1725)) | ||
| * Updated `protocol.rst` with new wording for error message ([#1662](https://github.com/opensearch-project/sql/pull/1662)) | ||
| * Updated documentation for temporal data types ([#1826](https://github.com/opensearch-project/sql/pull/1826)) |
Collaborator
Collaborator
|
@MaxKsyunz UPD |
acarbonetto
approved these changes
Jul 14, 2023
matthewryanwells
approved these changes
Jul 18, 2023
forestmvey
approved these changes
Jul 18, 2023
MitchellGale
approved these changes
Jul 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
Signed-off-by: Max Ksyunz <[email protected]> (cherry picked from commit 761e6a4)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
Signed-off-by: Max Ksyunz <[email protected]> (cherry picked from commit 761e6a4)
MaxKsyunz
added a commit
that referenced
this pull request
Jul 18, 2023
Signed-off-by: Max Ksyunz <[email protected]> (cherry picked from commit 761e6a4) Co-authored-by: Max Ksyunz <[email protected]>
matthewryanwells
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 18, 2023
Signed-off-by: Max Ksyunz <[email protected]>
matthewryanwells
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 19, 2023
Signed-off-by: Max Ksyunz <[email protected]> Signed-off-by: Matthew Wells <[email protected]>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 20, 2023
Signed-off-by: Max Ksyunz <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 20, 2023
Signed-off-by: Max Ksyunz <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Jul 27, 2023
Signed-off-by: Max Ksyunz <[email protected]> (cherry picked from commit 761e6a4)
MaxKsyunz
added a commit
that referenced
this pull request
Jul 27, 2023
Signed-off-by: Max Ksyunz <[email protected]> (cherry picked from commit 761e6a4) Co-authored-by: Max Ksyunz <[email protected]>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 28, 2023
Signed-off-by: Max Ksyunz <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing comments on 2.9 release notes.