Skip to content

Conversation

@MaxKsyunz
Copy link
Collaborator

@MaxKsyunz MaxKsyunz commented Apr 21, 2023

Fix failing build due to upstream refactor.

Issues Resolved

#1570

Check List

  • All tests pass, including unit test, integration test and doctest
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Merging #1571 (d580570) into main (bc29a8a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #1571      +/-   ##
============================================
- Coverage     97.16%   97.16%   -0.01%     
+ Complexity     4117     4116       -1     
============================================
  Files           371      371              
  Lines         10366    10365       -1     
  Branches        704      704              
============================================
- Hits          10072    10071       -1     
  Misses          287      287              
  Partials          7        7              
Flag Coverage Δ
sql-engine 97.16% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch/sql/opensearch/client/OpenSearchNodeClient.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MaxKsyunz MaxKsyunz marked this pull request as draft April 21, 2023 17:16
@MaxKsyunz MaxKsyunz marked this pull request as ready for review April 24, 2023 17:02
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All CI pass except BWC. Can we ignore it for now?

Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can ignore bwc failed test.

@penghuo penghuo merged commit 4522422 into opensearch-project:main Apr 24, 2023
@penghuo
Copy link
Collaborator

penghuo commented Apr 24, 2023

Upstream change #1570 not backport to 2.x yet.

@MaxKsyunz MaxKsyunz deleted the chore/immutableopenmap-refactor branch April 27, 2023 05:42
acarbonetto pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Apr 28, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 27, 2023
Signed-off-by: MaxKsyunz <[email protected]>
(cherry picked from commit 4522422)
Yury-Fridlyand added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jun 27, 2023
Yury-Fridlyand added a commit that referenced this pull request Jun 27, 2023
* Update SQL plugin for core refactor (#1571)

Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>

* Fix plugin compilation (#1580)

* Changed gradle version and removed values iterator

Signed-off-by: Guian Gumpac <[email protected]>

* Update a test to match new indexResponse.aliases() type.

Signed-off-by: MaxKsyunz <[email protected]>

* Ran ./gradlew wrapper

Signed-off-by: Guian Gumpac <[email protected]>

---------

Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Co-authored-by: MaxKsyunz <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>

* Update sqlite-jdbc to 3.41.2.2 to address CVE-2023-32697 (#1667)

* Update sqlite-jdbc to 3.41.2.2 to address CVE-2023-32697

Signed-off-by: MaxKsyunz <[email protected]>

* Don't check column names on H2 results for correctness tests as described in #1667 (comment).

Signed-off-by: Yury-Fridlyand <[email protected]>

* Address PR review comment.

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Co-authored-by: MaxKsyunz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants