Skip to content

Conversation

@GabeFernandez310
Copy link
Contributor

Description

Adds the WeekOfYear function to the SQL plugin. It behaves like the week function which already exists in the new engine, and both are aligned with MySQL. It has been added as an alias.

Issues Resolved

722

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Added WeekOfYear As An Alias To Week Function

Signed-off-by: GabeFernandez310 <[email protected]>
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@dai-chen dai-chen added the enhancement New feature or request label Feb 16, 2023
@Yury-Fridlyand Yury-Fridlyand merged commit 114e02a into opensearch-project:main Feb 16, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 16, 2023
Added WeekOfYear As An Alias To Week Function

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 114e02a)
penghuo pushed a commit that referenced this pull request Feb 16, 2023
Added WeekOfYear As An Alias To Week Function

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 114e02a)

Co-authored-by: GabeFernandez310 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants