Skip to content

Conversation

@GabeFernandez310
Copy link
Contributor

Description

Adds support for the hour_of_day function as an alias for the hour function which currently exists in opensearch

Issues Resolved

#722

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Added Tests And ImplementationFor Hour_Of_Day Function

Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310 GabeFernandez310 requested a review from a team as a code owner January 5, 2023 19:18
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.90%. Comparing base (dc5578a) to head (0993de1).
⚠️ Report is 818 commits behind head on main.

❌ Your project status has failed because the head coverage (95.90%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1226      +/-   ##
============================================
- Coverage     98.34%   95.90%   -2.45%     
- Complexity     3594     3595       +1     
============================================
  Files           344      354      +10     
  Lines          8909     9572     +663     
  Branches        562      681     +119     
============================================
+ Hits           8762     9180     +418     
- Misses          142      334     +192     
- Partials          5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dai-chen
dai-chen previously approved these changes Jan 6, 2023
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

penghuo
penghuo previously approved these changes Jan 9, 2023
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflict.

@GabeFernandez310 GabeFernandez310 dismissed stale reviews from penghuo and dai-chen via 289ea8e January 9, 2023 23:04
Signed-off-by: GabeFernandez310 <[email protected]>
@penghuo
Copy link
Collaborator

penghuo commented Jan 10, 2023

BWC Test failed, let's ignore it for now.

@penghuo penghuo merged commit 9e67e5b into opensearch-project:main Jan 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
* Add Hour_Of_Day Function As An Alias Of Hour

Added Tests And ImplementationFor Hour_Of_Day Function

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 9e67e5b)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
* Add Hour_Of_Day Function As An Alias Of Hour

Added Tests And ImplementationFor Hour_Of_Day Function

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 9e67e5b)
penghuo pushed a commit that referenced this pull request Jan 10, 2023
* Add Hour_Of_Day Function As An Alias Of Hour

Added Tests And ImplementationFor Hour_Of_Day Function

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 9e67e5b)

Co-authored-by: GabeFernandez310 <[email protected]>
penghuo pushed a commit that referenced this pull request Jan 10, 2023
* Add Hour_Of_Day Function As An Alias Of Hour

Added Tests And ImplementationFor Hour_Of_Day Function

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 9e67e5b)

Co-authored-by: GabeFernandez310 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants