Skip to content

Conversation

@Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Dec 15, 2022

Description

The proposed fix suppresses errors from the uploading step. ref

Issues Resolved

Sometimes CI fails to upload test reports and marks that entire workflow had failed.
Example:
https://github.com/Bit-Quill/opensearch-project-sql/actions/runs/3681582096/jobs/6228417004#step:8:19

Seen only in SQL Java CI, I guess it is caused by big amount of files and/or big total zip size.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Yury-Fridlyand Yury-Fridlyand added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Dec 15, 2022
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner December 15, 2022 19:49
@Yury-Fridlyand
Copy link
Collaborator Author

1

Seen only in SQL Java CI

Should I update other CI workflows too?

2
Do we need a backport?

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.81%. Comparing base (5073215) to head (eb2c5ca).
⚠️ Report is 845 commits behind head on main.

❌ Your project status has failed because the head coverage (95.81%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1180      +/-   ##
============================================
- Coverage     98.31%   95.81%   -2.50%     
  Complexity     3521     3521              
============================================
  Files           342      352      +10     
  Lines          8701     9359     +658     
  Branches        554      673     +119     
============================================
+ Hits           8554     8967     +413     
- Misses          142      334     +192     
- Partials          5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Probably this only need to be back ported to branch where workflow runs frequently, ex 2.x?

@dai-chen dai-chen merged commit 683d92f into opensearch-project:main Jan 3, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the fix-ci-failures branch January 4, 2023 00:46
@Yury-Fridlyand
Copy link
Collaborator Author

Thanks for the fix! Probably this only need to be back ported to branch where workflow runs frequently, ex 2.x?

Yes, I'm going to backport to 2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 4, 2023
Signed-off-by: Yury-Fridlyand <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>
(cherry picked from commit 683d92f)
penghuo pushed a commit that referenced this pull request Jan 4, 2023
Signed-off-by: Yury-Fridlyand <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>
(cherry picked from commit 683d92f)

Co-authored-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants