-
Notifications
You must be signed in to change notification settings - Fork 179
Suppress CI failures not related to testing/building #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yury-Fridlyand <[email protected]>
|
1
Should I update other CI workflows too? 2 |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (95.81%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
============================================
- Coverage 98.31% 95.81% -2.50%
Complexity 3521 3521
============================================
Files 342 352 +10
Lines 8701 9359 +658
Branches 554 673 +119
============================================
+ Hits 8554 8967 +413
- Misses 142 334 +192
- Partials 5 58 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dai-chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Probably this only need to be back ported to branch where workflow runs frequently, ex 2.x?
Yes, I'm going to backport to 2.x. |
Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> (cherry picked from commit 683d92f)
Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> (cherry picked from commit 683d92f) Co-authored-by: Yury-Fridlyand <[email protected]>
Description
The proposed fix suppresses errors from the uploading step. ref
Issues Resolved
Sometimes CI fails to upload test reports and marks that entire workflow had failed.
Example:
https://github.com/Bit-Quill/opensearch-project-sql/actions/runs/3681582096/jobs/6228417004#step:8:19
Seen only in
SQL Java CI, I guess it is caused by big amount of files and/or big total zip size.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.