From 69a658e3007877fe591755f95057d3e511911653 Mon Sep 17 00:00:00 2001 From: David Cui Date: Wed, 5 May 2021 18:06:21 -0700 Subject: [PATCH 1/2] fixed no-error-output bug in workbench (#32) Signed-off-by: David Cui --- workbench/public/components/Main/main.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/workbench/public/components/Main/main.tsx b/workbench/public/components/Main/main.tsx index 2ff52b90b05..625c485f80e 100644 --- a/workbench/public/components/Main/main.tsx +++ b/workbench/public/components/Main/main.tsx @@ -276,8 +276,11 @@ export class Main extends React.Component { let err = response.data.resp; console.log("Error occurred when processing query response: ", err) - // Mark fulfilled to true as long as the data is fulfilled - if (response.data.body) { + // Exclude a special case from the error cases: + // When downloading the csv result, it gets the "Unable to parse/serialize body" response + // But data is also returned in data body. For this case: + // Mark fulfilled to true for this case to write the csv result to downloading file + if (response.data.body && err == "Unable to parse/serialize body") { return { fulfilled: true, errorMessage: err, @@ -287,6 +290,7 @@ export class Main extends React.Component { return { fulfilled: false, errorMessage: err, + data: '' }; } From fb4b16a7f1eda844a2615d64780a72c8bb0f9ceb Mon Sep 17 00:00:00 2001 From: David Cui Date: Mon, 7 Jun 2021 09:35:10 -0700 Subject: [PATCH 2/2] amend release notes, leave out workbench fix Signed-off-by: David Cui --- release-notes/opensearch-sql.release-notes-1.0.0.0-rc1.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/release-notes/opensearch-sql.release-notes-1.0.0.0-rc1.md b/release-notes/opensearch-sql.release-notes-1.0.0.0-rc1.md index 63fa9554bc0..1a62196d8dc 100644 --- a/release-notes/opensearch-sql.release-notes-1.0.0.0-rc1.md +++ b/release-notes/opensearch-sql.release-notes-1.0.0.0-rc1.md @@ -6,9 +6,6 @@ Compatible with OpenSearch and OpenSearch Dashboards Version 1.0.0-rc1 * Support querying a data stream ([#56](https://github.com/opensearch-project/sql/pull/56)) -### Bug Fixes -* Fix Breadcrumb display in Query Workbench ([#105](https://github.com/opensearch-project/sql/pull/105)) - ### OpenSearch Migration * Remove debug logging in ODBC driver ([#27](https://github.com/opensearch-project/sql/pull/27))