Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and possibly move static method for determining local ephemeral address #49

Closed
dbwiddis opened this issue Jul 13, 2022 · 0 comments
Closed

Rename and possibly move static method for determining local ephemeral address #49

dbwiddis opened this issue Jul 13, 2022 · 0 comments
Assignees
@mloufra
Labels
good first issue Good for newcomers

Comments

@dbwiddis
Copy link
Member

The ActionListener class has a protected static method getLocalEphemeral().

  • Subclasses can't access static method so protected access is inappropriate. Consider making private if only this class will use it. Consider refactoring to another class if it's going to be used by other classes
  • As it's not a field accessor, get*() is not the best name. Consider createLocalEphemeralAddress().

See #45 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mloufra mloufra

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbwiddis @owaiskazi19 @mloufra