Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard repo code coverage metrics #93

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Oct 29, 2024

Description

Onboard repo code coverage metrics and mechanism to link with existing release metrics.

"_source": {
    "coverage": 43.41,
    "current_date": "2024-10-28T17:54:41.742113549",
    "component": "customImportMapDashboards",
    "id": "b10b960e-b31f-3cb1-9a55-5e87ed2ade6b",
    "commitid": "511840ae5ca900610d521aad311677445269055f",
    "state": "complete",
    "repository": "dashboards-maps",
    "release_version": "2.18.0",
    "release_state": "open",
    "version": "2.18.0",
    "branch": "2.18",
    "url": "https://api.codecov.io/api/v2/github/opensearch-project/repos/dashboards-maps/commits?branch=2.18"
  },
  "_source": {
    "coverage": 0,
    "current_date": "2024-10-28T17:54:41.742113549",
    "component": "OpenSearch",
    "id": "09c026db-49b3-3502-ae80-717c6db4b8e1",
    "commitid": "none",
    "state": "no-coverage",
    "repository": "OpenSearch",
    "release_version": "2.18.0",
    "release_state": "open",
    "version": "2.18.0",
    "branch": "2.18",
    "url": "https://api.codecov.io/api/v2/github/opensearch-project/repos/OpenSearch/commits?branch=2.18"
  },

Issues Resolved

Part of #51 and #90

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 93.44262% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.58%. Comparing base (6c900a3) to head (3a1cffd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...opensearchmetrics/model/codecov/CodeCovResult.java 87.50% 4 Missing ⚠️
.../opensearchmetrics/metrics/MetricsCalculation.java 94.11% 2 Missing ⚠️
...va/org/opensearchmetrics/dagger/MetricsModule.java 0.00% 1 Missing ⚠️
...ensearchmetrics/model/codecov/CodeCovResponse.java 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #93      +/-   ##
============================================
+ Coverage     84.53%   86.58%   +2.04%     
- Complexity      228      271      +43     
============================================
  Files            61       64       +3     
  Lines          1371     1491     +120     
  Branches         56       58       +2     
============================================
+ Hits           1159     1291     +132     
+ Misses          189      177      -12     
  Partials         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterzhuamazon
Copy link
Member

Seems like we need to increase the test coverage of this PR?

@prudhvigodithi
Copy link
Member Author

Seems like we need to increase the test coverage of this PR?

Let me see @peterzhuamazon, the codecov complains missing coverage for single lines in middle of the code,

@prudhvigodithi prudhvigodithi force-pushed the central branch 3 times, most recently from 0f1824d to c6e8e38 Compare October 29, 2024 20:33
@prudhvigodithi prudhvigodithi force-pushed the central branch 2 times, most recently from 5a9155a to d349f2c Compare October 29, 2024 20:40
Signed-off-by: Prudhvi Godithi <[email protected]>
@prudhvigodithi prudhvigodithi merged commit 157464b into opensearch-project:main Oct 29, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants