Changes for adding benchmark compare feature #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh6788
requested review from
dblock,
peterzhuamazon,
gaiksaya,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4931 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 197 197
Lines 6634 6634
=======================================
Hits 6131 6131
Misses 503 503 ☔ View full report in Codecov by Sentry. |
Comment on lines
294
to
303
| // Trigger compare-benchmarks job | ||
| build job: 'compare-benchmarks', | ||
| parameters: [ | ||
| string(name:'BASELINE_TEST_EXECUTION_ID', value: "${benchmarkTestIds.baseline}"), | ||
| string(name:'BASELINE_TEST_EXECUTION_ID', value: "${benchmarkTestIds.contender}"), | ||
| string(name:'PULL_REQUEST_NUMBER', value: "${pull_request_number}"), | ||
| string(name:'REPOSITORY', value: "${repository}") | ||
| ], | ||
| wait: false, | ||
| propagate: false |
|
peterzhuamazon
approved these changes
Aug 9, 2024
| pullRequestNumber: "${pull_request_number}" | ||
| ) | ||
| // Trigger compare-benchmarks job | ||
| build job: 'compare-benchmarks', |
There was a problem hiding this comment.
Nit: Possible of changing this to benchmark-compare to in sync with other benchmark workflow naming convention?
Thanks.
Signed-off-by: Rishabh Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
compare-benchmarksto run benchmark comparison between baseline and target run.benchmark-pull-requestjob to callcompare-benchmarksjob once it is successfully finished to also update the comparison results on the calling pull_request.Issues Resolved
opensearch-project/OpenSearch#14826.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.