Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script similar to gradle-check to invoke benchmark-pull-request job from github actions workflow #4846

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

rishabh6788
Copy link
Collaborator

@rishabh6788 rishabh6788 commented Jul 15, 2024

Description

Add a script similar to gradle-check that gets executed during github workflow execution to submit new builds for benchmark-pull-request using generic webhook token.

Since this workflow will not be part of CI approval actions, it is safe to just submit the job and update the PR with job link, than to keep polling the job till it finishes. Also, some jobs can take 3-4 hours to finish.

Issues Resolved

opensearch-project/OpenSearch#14553
#4845

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rishabh6788
Copy link
Collaborator Author

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about putting this script in build-lib repo?
For a workflow running in OpenSearch repo, the scripts are all over the place. I think OS or build-lib should be the right place. I believe even the gradle-check script should be moved. WDYT?

@rishabh6788
Copy link
Collaborator Author

How about putting this script in build-lib repo? For a workflow running in OpenSearch repo, the scripts are all over the place. I think OS or build-lib should be the right place. I believe even the gradle-check script should be moved. WDYT?

Thanks for the feedback @gaiksaya.
Can I merge this for now and track the movement of all the scripts to build library repo in another issue?

@rishabh6788
Copy link
Collaborator Author

Merging this and will track scripts migration task in another issue.

@rishabh6788 rishabh6788 merged commit 1426f43 into opensearch-project:main Jul 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants