Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the path for maven sign and staging job #1954

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Apr 11, 2022

Signed-off-by: Zelin Hao [email protected]

Description

The old jenkins job used to upload the signed maven artifacts from builds/opensearch/maven to a new folder called maven-signed and downloaded it again before staging. I skipped that step in this workflow because the entire process is within the same workspace.
This PR changed the path for signed maven artifacts used for staging.

Issues Resolved

#1893

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh zelinh self-assigned this Apr 11, 2022
@zelinh zelinh requested a review from a team as a code owner April 11, 2022 21:54
@zelinh zelinh changed the title Fix the path for staging maven Fix the path for maven sign and staging job Apr 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #1954 (1f02c4e) into main (036be2d) will increase coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1954      +/-   ##
============================================
+ Coverage     94.46%   94.60%   +0.13%     
============================================
  Files           179      140      -39     
  Lines          3649     3519     -130     
  Branches         29       19      -10     
============================================
- Hits           3447     3329     -118     
+ Misses          196      190       -6     
+ Partials          6        0       -6     
Impacted Files Coverage Δ
src/system/temporary_directory.py 83.87% <0.00%> (-12.91%) ⬇️
src/system/os.py 93.75% <0.00%> (-6.25%) ⬇️
tests/jenkins/jobs/BuildArchive_Jenkinsfile
tests/jenkins/jobs/BuildManifest_Jenkinsfile
tests/jenkins/jobs/RunIntegTestScript_Jenkinsfile
tests/jenkins/jobs/PublishNotification_Jenkinsfile
...ts/jenkins/jobs/uploadMinSnapshotsToS3_Jenkinsfile
src/jenkins/TestManifest.groovy
tests/jenkins/jobs/RunBwcTestScript_Jenkinsfile
tests/jenkins/jobs/InputManifest_Jenkinsfile
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 036be2d...1f02c4e. Read the comment docs.

@zelinh
Copy link
Member Author

zelinh commented Apr 11, 2022

Working on the test and support for new distribution folder.

@zelinh
Copy link
Member Author

zelinh commented Apr 11, 2022

New test run with ARTIFACT_PATH including tar on 3.0.0 artifacts and these are the staging contents:

Screen Shot 2022-04-11 at 3 58 37 PM

@dblock dblock merged commit 70a316a into opensearch-project:main Apr 11, 2022
@zelinh zelinh linked an issue Apr 11, 2022 that may be closed by this pull request
@zelinh zelinh deleted the maven-path-fix branch April 11, 2022 23:11
prudhvigodithi pushed a commit to prudhvigodithi/opensearch-build that referenced this pull request Apr 13, 2022
…arch-project#1947)

Signed-off-by: Sagar Upadhyaya <[email protected]>

Adding code block for maven plugin zips

Signed-off-by: pgodithi <[email protected]>

Adding code block for maven plugin zips

Signed-off-by: pgodithi <[email protected]>

zip maven publish

Signed-off-by: pgodithi <[email protected]>

added zipsmaven dir check

Signed-off-by: pgodithi <[email protected]>

Adding better gradle project dir

Signed-off-by: pgodithi <[email protected]>

test maven snapshots

Signed-off-by: pgodithi <[email protected]>

test maven snapshots

Signed-off-by: pgodithi <[email protected]>

test maven snapshots

Signed-off-by: pgodithi <[email protected]>

test maven snapshots

Signed-off-by: pgodithi <[email protected]>

test maven snapshots

Signed-off-by: pgodithi <[email protected]>

test maven snapshots

Signed-off-by: pgodithi <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

Removing build script for PA (opensearch-project#1952)

Signed-off-by: Sagar Upadhyaya <[email protected]>

update release issue with steps to update ansible and helm (opensearch-project#1942)

* update release issue with steps to update ansible and helm

Signed-off-by: Abhinav Gupta <[email protected]>

* updated test as sample PR

Signed-off-by: Abhinav Gupta <[email protected]>

* adding periods

Signed-off-by: Abhinav Gupta <[email protected]>

Fix the path for maven sign and staging job (opensearch-project#1954)

* Fix the path for staging maven

Signed-off-by: Zelin Hao <[email protected]>

* Add the distribution folder tar to the artifact path and update test

Signed-off-by: Zelin Hao <[email protected]>

[OSD][2.0.0] use rc1 qualifier (opensearch-project#1949)

Signed-off-by: Kawika Avilla <[email protected]>

install createrepo in docker image for RPM yum repo support (opensearch-project#1955)

* install createrepo in docker image for RPM yum repo support

Signed-off-by: Tianle Huang <[email protected]>

* fix

Signed-off-by: Tianle Huang <[email protected]>

* update opensearch to use new image

Signed-off-by: Tianle Huang <[email protected]>

Add systemd docker for rpm service test (opensearch-project#1958)

* Add systemd based image for yum install testing and more

Signed-off-by: Peter Zhu <[email protected]>

* More packages to add to the images

Signed-off-by: Peter Zhu <[email protected]>

lower freq for build for 1.3.1 opensearch-dashboards (opensearch-project#1941)

* lower freq for build for 1.3.1 opensearch-dashboards

Signed-off-by: Abhinav Gupta <[email protected]>

* removed build for 1.2.x and 1.3.1

Signed-off-by: Abhinav Gupta <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

Added notifications-core and notifications to 2.0 and add integTest manifest (opensearch-project#1957)

* Added notifications-core and notifications to 2.0.

Signed-off-by: dblock <[email protected]>

* Remove scripts from opensearch-build.

Signed-off-by: dblock <[email protected]>

* Remove dashboards notifications scripts to use the default one

Signed-off-by: Peter Zhu <[email protected]>

* Remove CI checks for lack of gradlew.

Signed-off-by: dblock <[email protected]>

* Fix the second subfolder location after core

Signed-off-by: Peter Zhu <[email protected]>

* Add notifications related build scripts to build repo

Signed-off-by: Peter Zhu <[email protected]>

* Tweak build scripts to correctly move the zips

Signed-off-by: Peter Zhu <[email protected]>

Co-authored-by: Peter Zhu <[email protected]>

Make sure notifications is built correctly while passing ci checks (opensearch-project#1959)

Signed-off-by: Peter Zhu <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>

test snapshot build

Signed-off-by: pgodithi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] New maven sign and upload pipeline fail since 1.3.0
4 participants