Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Remove psutil as a dependency in Pipfile #597

Closed
peterzhuamazon opened this issue Sep 24, 2021 · 3 comments
Closed

[Bug] Remove psutil as a dependency in Pipfile #597

peterzhuamazon opened this issue Sep 24, 2021 · 3 comments
Labels
bug Something isn't working untriaged Issues that have not yet been triaged

Comments

@peterzhuamazon
Copy link
Member

Describe the bug

I am not sure why pstuil is being added as dependency in bundle-workflow.
https://github.com/opensearch-project/opensearch-build/blob/main/bundle-workflow/Pipfile#L24
It is not supported in many places.

  1. It does not support arm64 arch listed here: [Linux] Publish armv7l & aarch64 wheels giampaolo/psutil#1966
  2. It does not support Windows on cygwin: Cygwin Support giampaolo/psutil#82 (issue opened in 2010 and a contributor attempt to work on it but PR closed later)

It is only used right here for test:
https://github.com/opensearch-project/opensearch-build/blob/927d87b59b369f00b2a366c4f29ffb0d7ff3d342/bundle-workflow/src/test_workflow/integ_test/local_test_cluster.py

@setiah @gaiksaya can you chime in for more information on why we need this?
Or we can have a path on how to resolve this later.

To reproduce

See above.

Expected behavior

No response

Screenshots

If applicable, add screenshots to help explain your problem.

Host / Environment

No response

Additional context

No response

Relevant log output

No response

@gaiksaya
Copy link
Member

The issue was resolved by installting python3-devel on the host machine.
See #527 for more details.
It is used to grab the child processes id.

@peterzhuamazon
Copy link
Member Author

It still does not work on windows.

@dblock
Copy link
Member

dblock commented Sep 24, 2021

It still does not work on windows.

Many other things don't work on windows in our build AFAIK, I think we can fix it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged Issues that have not yet been triaged
Projects
None yet
Development

No branches or pull requests

3 participants